Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fmt): Improve terminal styling support #298

Merged
merged 13 commits into from
Jan 19, 2024
Merged

fix(fmt): Improve terminal styling support #298

merged 13 commits into from
Jan 19, 2024
+350 −887

Conversation

epage
Copy link
Contributor

@epage epage commented Jan 18, 2024 •
edited
Loading

This switches the backend to anstream

This comes with an MSRV bump to 1.70. This allows us to use the latest anstream and avoid is-terminal.

BREAKING CHANGE: Formatter::style, Formatter::default_styled_level, Color, Style, and StyledValue were removed. Formatter::default_level_style was changed to return anstyle::Style.

Fixes #274
Fixes #276

epage added 13 commits January 17, 2024 20:41
@epage
chore: Bump MSRV to 1.71
a77a761 
- 1.70.0 is needed for `anstream` to be added
- 1.71.0 is needed for changes to how cargo treats features
@epage
perf: Remove is-terminal dependency
fb603ba 
Fixes rust-cli#276
@epage
fix(fmt)!: Remove color support

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5cbbff9
@epage
refactor(fmt): Flatten mods
0016e2c
@epage
refactor(fmt): Inline the print call
1c50358
@epage
refactor(fmt): Pull in Target to its only use
f3de55b
@epage
feat(fmt): Add back color support
bce8463 
This also adds support for `NO_COLOR` and `CLICOLOR_FORCE`, see https://bixense.com/clicolors/
@epage
feat(fmt): Add back in Formatter::default_level_style
7d5b72a
@epage
docs: Add back in custom colors
2f3ca7d
@epage
feat(fmt): Add back in level styling
303a9c0
@epage
fix(fmt): Print colors for tests
4276f5f 
This was discussed in rust-cli#225 but no dedicated issue for it.
@epage
fix(fmt): Allow styling on the Pipe
730b0a0 
Fixes rust-cli#274
@epage
chore(fmt): Add debug impls
ea46409
This was referenced Jan 18, 2024
Open
Closed
Closed
Closed
@epage epage force-pushed the term branch 2 times, most recently from 2dc048f to ea46409 Compare January 18, 2024 20:02
@epage epage mentioned this pull request Jan 18, 2024
Closed
@epage epage merged commit 2089053 into rust-cli:main Jan 19, 2024
@epage epage deleted the term branch January 19, 2024 16:52
@Bobo1239 Bobo1239 mentioned this pull request Jan 27, 2024
Merged
@epage epage mentioned this pull request Feb 13, 2024
Closed
epage added a commit to epage/env_logger that referenced this pull request Feb 13, 2024
@epage
docs(fmt): Talk about new styling API
c67579c 
The documentation for the old API was overlooked in rust-cli#298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace is-terminal dep with std::io::IsTerminal WriteStyle is ignored when used with Target::Pipe
1 participant
@epage