Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Deprecation Without Warning or Migration #309

Closed
TylerJMcLean opened this issue Feb 13, 2024 · 3 comments
Closed

Feature Deprecation Without Warning or Migration #309

TylerJMcLean opened this issue Feb 13, 2024 · 3 comments

Comments

@TylerJMcLean
Copy link

The [color] feature was removed in 0.11 with (from what I can see) no explanation as to why, and no deprecation warnings that would suggest this was coming.

  • Why was this feature removed?
  • What (if any) is the migration pathway exists for users of this feature?
@epage
Copy link
Contributor

epage commented Feb 13, 2024

What do you mean by "[color] feature".

The Cargo.toml feature color is still present.

If you mean the bespoke formatting API under fmt, you do have to read a little between the lines in the changelog. That could be more clear.

The key feature is

Automatically adapt ANSI escape codes in logged messages to the current terminal's capabilities

You are now free to use whatever styling API you want to generate ANSI styled strings and pass them to env_logger. env_logger will adapt them to the current system as needed, even to the legacy wincon API.

See also #298

@epage
Copy link
Contributor

epage commented Feb 13, 2024

Created #310 to fill some API gaps

@TylerJMcLean
Copy link
Author

Hey @epage, yeah I should have been more specific on versioning when I wrote this. I noticed between 10.2->11.0 color code had been removed and though the color feature had appeared to be restored in 11.1, there was no bespoke mention of how one using the previous API could update their code. #310 covers exactly what I'm looking for. Thank you for your speedy response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants