fix: Target::Pipe respects WriteStyle
#275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What exactly does this PR change? I only see renamed variables, a cast that I don't think is necessary and some |
miraclx
commented
Aug 9, 2023
Comment on lines
111
to
114
| has_alt_target: matches!( | ||
| self.alt_target, | ||
| Some(WritableTarget::Stderr | WritableTarget::Stdout) | ||
| ), |
There was a problem hiding this comment.
@matthiasbeyer, this. The variable rename should make sense in this context, and since I was already modifying the lines, I figured a rewrite to the then_some syntax was ideal.
As for the cast, rust-analyzer kept hinting at a type conflict that rustc didn't flag. Adding an arbitrary typecast was the quickest way to remove the error.
|
This is superseded by #298 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #274.
The old behavior made it impossible to retain colors in custom sinks.
With this patch, the default behavior assumes non-color compliance with the sink. But this can be overridden with
WriteStyle::Always.