[Privatization] Skip variable assign append on ChangeReadOnlyVariableWithDefaultValueToConstantRector #3687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
requested changes
Apr 25, 2023
samsonasik
reviewed
Apr 26, 2023
...ngeReadOnlyVariableWithDefaultValueToConstantRector/Fixture/skip_variable_assignment.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Apr 26, 2023
...ngeReadOnlyVariableWithDefaultValueToConstantRector/Fixture/skip_variable_assignment.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
requested changes
Apr 26, 2023
There was a problem hiding this comment.
Please rename PR title to something like:
[Privatization] Skip variable assign append on ChangeReadOnlyVariableWithDefaultValueToConstantRector
Also, could you make CI green, see error
https://github.com/rectorphp/rector-src/actions/runs/4803271285/jobs/8547601933?pr=3687#step:5:18
mickeytodd
changed the title
|
@samsonasik could you please check why testing fails on Renaming/Rector/FileWithoutNamespace/PseudoNamespaceToNamespaceRector/Fixture/namespace_split.php.inc? I didn't change that file. Thanks! |
|
I am not sure, could you try rebase? If still happen, try revert your change, if still happen, it possibly due to duplicated fixture files |
|
Test failure fixed at #3691, please rebase |
|
@mickeytodd @samsonasik Thanks for fixing this so quickly! |
samsonasik
pushed a commit
that referenced
this pull request
May 8, 2023
…WithDefaultValueToConstantRector (#3687) * fix: checking for other modifying types * fix: added fixture * fix: changed class name * fix: checking if parent class is null * fix: checking for all types of assigning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes rectorphp/rector#7900