Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NodeManipulator] clean up multiple instanceof check on AssignManipulator #3695

Merged
merged 2 commits into from Apr 28, 2023
Merged

[NodeManipulator] clean up multiple instanceof check on AssignManipulator #3695

merged 2 commits into from Apr 28, 2023

Conversation

samsonasik
Copy link
Member

@mickeytodd this is to clean up multiple assign repetitive usage, by merge with Assign + pre-defined constant on PR:

@samsonasik samsonasik changed the title clean up multiple instanceof check on AssignManipulator [NodeManipulator] clean up multiple instanceof check on AssignManipulator Apr 28, 2023
@samsonasik samsonasik enabled auto-merge (squash) April 28, 2023 00:41
@samsonasik samsonasik merged commit 181b6c9 into main Apr 28, 2023
40 checks passed
@samsonasik samsonasik deleted the clean-up branch April 28, 2023 00:54
@samsonasik samsonasik mentioned this pull request Apr 28, 2023
Merged
samsonasik added a commit that referenced this pull request May 8, 2023
@samsonasik
[NodeManipulator] clean up multiple instanceof check on AssignManipul…
3d7e89f 
…ator (#3695)

* clean up multiple instanceof check on AssignManipulator

* use var type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@samsonasik