[Privatization] Skip variable assign append on ChangeReadOnlyVariable…

…WithDefaultValueToConstantRector (#3687)

* fix: checking for other modifying types

* fix: added fixture

* fix: changed class name

* fix: checking if parent class is null

* fix: checking for all types of assigning

rules-tests/Privatization/Rector/Class_/ChangeReadOnlyVariableWithDefaultValueToConstantRector/Fixture/skip_variable_array_append.php.inc

@@ -0,0 +1,21 @@
+<?php
+
+namespace Rector\Tests\Privatization\Rector\Class_\ChangeReadOnlyVariableWithDefaultValueToConstantRector\Fixture;
+
+final class SkipVariableArrayAppend
+{
+    /**
+     * @var string[]
+     */
+    private const VALUES = ['a', 'b', 'c', 'd', 'e', 'a', 'b', 'c', 'd', 'e'];
+
+    public function run()
+    {
+        $arr = [];
+        foreach (self::VALUES as $key => $value) {
+            $arr[$value] ??= 0;
+            $arr[$value] += $key;
+        }
+        return $arr;
+    }
+}

src/NodeManipulator/AssignManipulator.php

@@ -93,7 +93,7 @@ public function isLeftPartOfAssign(Node $node): bool
                 $parentNode = $parentNode->getAttribute(AttributeKey::PARENT_NODE);
             }
 
-            if ($parentNode instanceof Assign) {
+            if ($parentNode instanceof Assign || $parentNode instanceof AssignOp || $parentNode instanceof PreDec || $parentNode instanceof PreInc || $parentNode instanceof PostDec || $parentNode instanceof PostInc) {
                 return $parentNode->var === $previousParent;
             }
         }