New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiline comments in PullRequest #2540
Allow multiline comments in PullRequest #2540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minor comments.
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
Co-authored-by: Steve Kowalik <steven@wedontsleep.org>
Note: This is a breaking change. The order of parameters of `PullRequest.get_review_comments` has changed to match other `get_comments` methods and Github API parameter order. Users should change `PullRequest.get_review_comments(since)` to `PullRequest.get_review_comments(since=since)`. Calling without parameter is not breaking: `PullRequest.get_review_comments()`
This adds argument `auth` and deprecates `login_or_token`, `password`, `jwt`, and `app_auth` arguments of `github.Github`. This adds argument `auth` and deprecates `integration_id`, `private_key` of `github.GithubIntegration`. This deprecates the `create_jwt` method of `github.GithubIntegration`, replaced by `github.Auth.AppAuth.create_jwt`.
…ven (#2543) Fixes slug attribute to fetch app when not set. Loads app with slug lazily, fetch complete app without slug.
Allows to refresh Github App user token. Integrates `ApplicationOAuth` into `github.Auth`.
…st for 'as_suggestion'
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2540 +/- ##
==========================================
+ Coverage 98.47% 98.50% +0.02%
==========================================
Files 128 128
Lines 12733 12751 +18
==========================================
+ Hits 12539 12560 +21
+ Misses 194 191 -3
☔ View full report in Codecov by Sentry. |
fix(PullRequest.create_review_comment): Change default from None to NotSet Co-authored-by: Enrico Minack <github@enrico.minack.dev>
…otSet Co-authored-by: Enrico Minack <github@enrico.minack.dev>
…10254c2 …otSet Co-authored-by: Enrico Minack <github@enrico.minack.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution!
change deprecated parameter: position -> line
add a parameter to allow multiline comment: start_line
add a parameter to allow comment as suggestion: as_suggestion