Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a review comment for a pull request using deprecated position parameter #2404

Closed
niro-lightspin opened this issue Jan 25, 2023 · 2 comments
Closed

Create a review comment for a pull request using deprecated position parameter #2404

niro-lightspin opened this issue Jan 25, 2023 · 2 comments

Comments

@niro-lightspin
Copy link

according to API docs the position parameter is deprecated but PyGithub is still using it so I get this error:

TypeError: create_review_comment() missing 1 required positional argument: 'position'

New API arguments are not working:

TypeError: create_review_comment() got an unexpected keyword argument 'line'
@heitorpolidoro
Copy link
Contributor

Hi,

I created this pull request #2540 that might fix this issue

@heitorpolidoro heitorpolidoro mentioned this issue May 31, 2023
Merged
@EnricoMi
Copy link
Collaborator

This has been fixed in #2540.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@heitorpolidoro @EnricoMi @niro-lightspin