Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PullRequest create_comment to support new changes #2517

Closed
talboren opened this issue May 7, 2023 · 2 comments
Closed

PullRequest create_comment to support new changes #2517

talboren opened this issue May 7, 2023 · 2 comments

Comments

@talboren
Copy link

talboren commented May 7, 2023

Seems like PullRequest create_comment (create_review_comment) is outdated according to https://docs.github.com/en/rest/pulls/comments?apiVersion=2022-11-28#create-a-review-comment-for-a-pull-request (for instance, the subject_type option or position -> line)

I can open a PR from my forked version--looking to see if it's relevant or someone is already working on it.
@heitorpolidoro
Copy link
Contributor

Hi,

I created this pull request #2540 that might fix this issue

@heitorpolidoro heitorpolidoro mentioned this issue May 31, 2023
Merged
@EnricoMi
Copy link
Collaborator

This has been fixed in #2540.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@heitorpolidoro @EnricoMi @talboren