Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline Comment #2095

Closed
sangwoo-joh opened this issue Oct 29, 2021 · 5 comments
Closed

Multiline Comment #2095

sangwoo-joh opened this issue Oct 29, 2021 · 5 comments

Comments

@sangwoo-joh
Copy link

Thanks for the great package!
It seems like there is no support for multi-line comments yet.
In GitHub Docs, we can create a comment that applies to more than one line in the pull request diff, by specifying line, side, start_line and start_side instead of a single parameter position.
Is there any plan to support this API?

@sangwoo-joh
Copy link
Author

sangwoo-joh commented Nov 22, 2021

I found some related issues, and maybe this feature is deliberately not supported because it is a preview feature? 😅

@sangwoo-joh
Copy link
Author

sangwoo-joh commented Nov 22, 2021

Hmm.. but it seems like some features are actually based on preview features, so if it is ok to have additional preview feature, I think I can contribute.

@sangwoo-joh
Copy link
Author

Possible combinations of parameters

  • Required: owner, repo, pull_number, body, commit_id, path
  • position (if this is used, the parameters below are ignored)
  • side (LEFT or RIGHT) + line (just like one-line comment using position only)
  • side + start_side + line + start_line (multi-line comment)

@heitorpolidoro
Copy link
Contributor

Hi,

I created this pull request #2540 that might fix this issue

@EnricoMi
Copy link
Collaborator

This has been fixed in #2540.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants