Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Update CI workflow #206

Merged
merged 11 commits into from Feb 7, 2024
Merged

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Feb 7, 2024

Pull Request description

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved

@xmnlab
Copy link
Contributor Author

xmnlab commented Feb 7, 2024

@Saransh-cpp , this was the issue: psf/black#3932

hope to have ruff as default soon, instead of black XD

@xmnlab
Copy link
Contributor Author

xmnlab commented Feb 7, 2024

@Saransh-cpp , sorry for changing too much in this PR.
but I think it is necessary to have that sooner than later
also I fixed some small issues

@xmnlab xmnlab mentioned this pull request Feb 7, 2024
11 tasks
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @xmnlab! This looks great!

I also noticed that a lot of fields in base.yaml are set to visible: false. Was there a reason for it? For instance, fields like project_layout, build_system, ..., should be visible in the CLI but they're not. Could you make them visible in this PR itself?

@xmnlab
Copy link
Contributor Author

xmnlab commented Feb 7, 2024

@Saransh-cpp , good catch!
you're right, it should be available in the base.yaml, and it could be hidden in the profile files

@xmnlab xmnlab merged commit 01870a3 into osl-incubator:main Feb 7, 2024
11 checks passed
@xmnlab xmnlab deleted the fix-black-on-ci branch February 7, 2024 21:02
Copy link

🎉 This PR is included in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants