Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the failing CI #205

Closed
wants to merge 4 commits into from
Closed

Conversation

Saransh-cpp
Copy link
Member

Pull Request description

Just a few changes in ruff's config.

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved

@Saransh-cpp
Copy link
Member Author

@xmnlab could you please check what is wrong with black here? The tests pass for me locally so I am unable to reproduce this locally.

The failing CI is blocking the new PRs. It would be great if this can be resolved as soon as possible.

@xmnlab
Copy link
Contributor

xmnlab commented Feb 7, 2024

@Saransh-cpp , I am still investigating that ... I will give you more updates soon

@xmnlab
Copy link
Contributor

xmnlab commented Feb 7, 2024

#206 should fix the issue, please, review it when you have time. thanks!

@Saransh-cpp Saransh-cpp closed this Feb 8, 2024
@Saransh-cpp Saransh-cpp deleted the fix-ci branch February 8, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants