Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcActions): remove aria-haspopup and aria-controls from navigation menu #5300

Merged
merged 1 commit into from Feb 26, 2024
Merged

fix(NcActions): remove aria-haspopup and aria-controls from navigation menu #5300

merged 1 commit into from Feb 26, 2024

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Feb 23, 2024 •
edited by susnux

☑️ Resolves

  • Resolves: "More apps" action button have two unneeded attrs: aria-haspopup and aria-controls. It is enough to have only aria-expanded in this case.

Every navigation "menu" which contains only links should not have additional attributes aria-haspopup and aria-controls.

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot from 2024-02-23 17-36-57 Screenshot from 2024-02-23 17-38-08

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@JuliaKirschenheuter
Remove aria-haspopup and aria-controls from navigation menu
b30baac 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Feb 23, 2024
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Feb 23, 2024
ShGKme
ShGKme approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works fine.

I'd add/change some comments to make it a bit cleaner, because it seems be very non-obvious

src/components/NcActions/NcActions.vue Show resolved Hide resolved
src/components/NcActions/NcActions.vue Show resolved Hide resolved
emoral435
emoral435 approved these changes Feb 24, 2024
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! :)

@ShGKme
Copy link
Contributor

ShGKme commented Feb 26, 2024 •
edited

I'd add/change some comments to make it a bit cleaner, because it seems be very non-obvious

I've marked these comments as resolved, because in another PR I'm refactoring all numerous a11y and keyboard navigation settings a bit into a single place with all comments in one place.

@JuliaKirschenheuter JuliaKirschenheuter merged commit 2110ea1 into master Feb 26, 2024
18 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/18-Remove_unnedeed_attrs_from_action_popup_with_links_and_allow_tab_navigation_through_the_elements branch February 26, 2024 09:01
@ShGKme ShGKme added bug Something isn't working feature: actions Related to the actions components accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Feb 26, 2024
@ShGKme ShGKme added this to the 8.7.2 milestone Feb 26, 2024
@ShGKme ShGKme changed the title Remove aria-haspopup and aria-controls from navigation menu fix(NcActions): remove aria-haspopup and aria-controls from navigation menu Feb 26, 2024
@ShGKme ShGKme mentioned this pull request Feb 26, 2024
Merged
3 tasks
@ShGKme
Copy link
Contributor

ShGKme commented Feb 26, 2024

/backport to next

@backportbot backportbot bot mentioned this pull request Feb 26, 2024
Merged
2 tasks
@Antreesy Antreesy mentioned this pull request Feb 29, 2024
Closed
@ShGKme ShGKme mentioned this pull request Feb 29, 2024
Merged
@ShGKme ShGKme modified the milestones: 8.7.2, 8.8.0 Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@emoral435 emoral435 emoral435 approved these changes

@susnux susnux Awaiting requested review from susnux

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: actions Related to the actions components
Projects
None yet
Milestone
8.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JuliaKirschenheuter @ShGKme @emoral435