fix(NcPopover): make popupRole non-required #5306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
requested review from
susnux,
JuliaKirschenheuter,
Pytal and
emoral435
JuliaKirschenheuter
approved these changes
Feb 26, 2024
|
Found one more issue |
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/nc-popover--required-popup-role
branch
from
b826ff8
to
760f518
Compare
susnux
approved these changes
Feb 26, 2024
|
/backport to next |
2 tasks
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
aria-haspopupandaria-controlsfrom navigation menu #5300popupRolewas made non-required inNcPopoverbut then it should also be non-required inNcPopoverTriggerProvideraria-haspopupis not required now, it should not be checked when checking for required attrs🏁 Checklist
nextrequested with a Vue 3 upgrade