[next] fix(NcActions): remove aria-haspopup and aria-controls from navigation menu
#5307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
backportbot
bot
requested review from
emoral435,
ShGKme and
JuliaKirschenheuter
backportbot
bot
added
bug
ShGKme
approved these changes
Feb 26, 2024
ShGKme
force-pushed
the
backport/5300/next
branch
from
5aa996d
to
d900fb8
Compare
|
As I understand, our next backport is for upgrading NcVue to 9.0.0 (Vue3), but even despite that, this should still be included, no? I could understand it wrong, though :) |
Nice catch, backport is broken |
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
ShGKme
force-pushed
the
backport/5300/next
branch
from
d900fb8
to
835316d
Compare
JuliaKirschenheuter
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5300
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.