Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DAV functions for fetching nodes from Nextcloud #706

Merged
merged 1 commit into from Jul 26, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 26, 2023

Based on #705 which is based on #704 so the first commits are unrelated.

This adds some DAV functions like parsing DAV results to Nodes and provide the default request payloads for querying nodes / favorites.

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 83.58% and project coverage change: -3.10% ⚠️

Comparison is base (883819c) 99.06% compared to head (15ce8e9) 95.97%.
Report is 4 commits behind head on master.

❗ Current head 15ce8e9 differs from pull request most recent head b2caac4. Consider uploading reports for the commit b2caac4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
- Coverage   99.06%   95.97%   -3.10%     
==========================================
  Files          11       14       +3     
  Lines         215      273      +58     
  Branches       70       82      +12     
==========================================
+ Hits          213      262      +49     
- Misses          1       10       +9     
  Partials        1        1              
Files Changed Coverage Δ
lib/files/folder.ts 100.00% <ø> (ø)
lib/files/node.ts 100.00% <ø> (ø)
lib/files/nodeData.ts 100.00% <ø> (ø)
lib/humanfilesize.ts 100.00% <ø> (ø)
lib/index.ts 100.00% <ø> (ø)
lib/permissions.ts 100.00% <ø> (ø)
lib/dav/dav.ts 57.69% <57.69%> (ø)
lib/dav/davPermissions.ts 100.00% <100.00%> (ø)
lib/dav/davProperties.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susnux susnux force-pushed the feat/dav-requests branch 2 times, most recently from f99a102 to 15ce8e9 Compare July 26, 2023 13:21
Also add missing doc string

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide WebDAV functions
2 participants