[Bug]: v27.1.6 - Deleted files view (`files_trashbin`) does not show deleted files #43134

Gummikavalier · 2024-01-25T19:09:59Z

⚠️ This issue respects the following points: ⚠️

This is a bug, not a question or a configuration/webserver/proxy issue.
This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
I agree to follow Nextcloud's Code of Conduct.

Bug description

When you delete any file, all previously deleted files disappear from the Deleted files view.
The files remain on the disk but it is not possible to make them visible.

This issue started at Nextcloud 27.1.6. It did not exist yet in 27.1.5.

Steps to reproduce

Delete any file in Nextcloud
Check the Deleted files view

Expected behavior

The deleted file should be visible under Deleted files.

Installation method

Community Manual installation with Archive

Nextcloud Server version

27

Operating system

RHEL/CentOS

PHP engine version

PHP 8.1

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated from a MINOR version (ex. 22.1 to 22.2)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

Default user-backend (database)
LDAP/ Active Directory
SSO - SAML
Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "27.1.6.2",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "theme": "",
        "maintenance": false,
        "mail_smtpmode": "smtp",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "loglevel": 2,
        "logtimezone": "Europe\/Helsinki",
        "trusted_domains": [
            "redacted from the output"
        ],
        "secret": "***REMOVED SENSITIVE VALUE***",
        "share_folder": "\/Shared",
        "trashbin_retention_obligation": "auto",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "https:\/\/redacted from the output\/",
        "htaccess.RewriteBase": "\/",
        "auth.bruteforce.protection.enabled": true,
        "mail_smtpauthtype": "LOGIN",
        "mail_smtpport": "25",
        "default_phone_region": "FI",
        "preview_max_memory": 256,
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_sendmailmode": "smtp",
        "mysql.utf8mb4": true
    }
}

List of activated Apps

Enabled:
  - activity: 2.19.0
  - admin_audit: 1.17.0
  - bruteforcesettings: 2.7.0
  - cloud_federation_api: 1.10.0
  - comments: 1.17.0
  - contactsinteraction: 1.8.0
  - dav: 1.27.0
  - federatedfilesharing: 1.17.0
  - federation: 1.17.0
  - files: 1.22.0
  - files_pdfviewer: 2.8.0
  - files_reminders: 1.0.0
  - files_rightclick: 1.6.0
  - files_sharing: 1.19.0
  - files_trashbin: 1.17.0
  - files_versions: 1.20.0
  - logreader: 2.12.0
  - lookup_server_connector: 1.15.0
  - notifications: 2.15.0
  - oauth2: 1.15.2
  - password_policy: 1.17.0
  - photos: 2.3.0
  - privacy: 1.11.0
  - provisioning_api: 1.17.0
  - recommendations: 1.6.0
  - serverinfo: 1.17.0
  - settings: 1.9.0
  - sharebymail: 1.17.0
  - systemtags: 1.17.0
  - text: 3.8.0
  - theming: 2.2.0
  - twofactor_backupcodes: 1.16.0
  - twofactor_totp: 9.0.0
  - viewer: 2.1.0
  - workflowengine: 2.9.0
Disabled:
  - circles: 27.0.1 (installed 22.1.1)
  - dashboard: 7.7.0 (installed 7.0.0)
  - encryption: 2.15.0
  - files_external: 1.19.0
  - firstrunwizard: 2.16.0 (installed 1.0)
  - nextcloud_announcements: 1.16.0 (installed 1.13.0)
  - related_resources: 1.2.0 (installed 1.1.0-alpha1)
  - support: 1.10.0 (installed 1.0.1)
  - survey_client: 1.15.0 (installed 1.10.0)
  - suspicious_login: 5.0.0
  - updatenotification: 1.17.0 (installed 1.0.1)
  - user_ldap: 1.17.0
  - user_status: 1.7.0 (installed 1.0.1)
  - weather_status: 1.7.0 (installed 1.2.0)

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

No response

Additional info

Also any previous deleted file in the view disappear after deleting one file running Nextcloud version 27.1.6.

The text was updated successfully, but these errors were encountered:

Dennis1993 · 2024-01-25T19:12:15Z

I can reproduce it. After upgrade to 27.1.6 the trash bin is always empty.

solracsf · 2024-01-25T20:09:19Z

Yes, there is a TypeError:

TypeError: (0 , d.parseWebdavPermissions) is not a function at v (https://nextcloud.tld/dist/files_trashbin-main.js?v=81952118-50:2:855)

ostasevych · 2024-01-25T20:26:08Z

Yes, there is a TypeError:

TypeError: (0 , d.parseWebdavPermissions) is not a function at v (https://nextcloud.tld/dist/files_trashbin-main.js?v=81952118-50:2:855)

are there any quick fixes?

Fixes #43134 Signed-off-by: Josh <josh.t.richards@gmail.com>

joshtrichards · 2024-01-25T22:39:41Z

At first I was confused because I thought this report was for v28 (which doesn't have this problem ironically).

Pretty certain it's supposed to be davParsePermissions though a quick look would lead me to believe it was an issue in v27.1.5 too.

As far as I can tell, parseWebdavPermissions was the legacy/interim API in nextcloud-files early on, but switched in nextcloud-libraries/nextcloud-files#706

My wild guess is this got overlooked in NC27 because so much of the F2V changes are in NC28.

Preliminary (untested) fix in #43136.

are there any quick fixes?

Not really. This code gets compiled so it's not as easy to monkey patch (unlike the PHP).

Fixes #43134 Signed-off-by: Josh <josh.t.richards@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

solracsf · 2024-01-26T05:08:40Z

Good catch!
Tested #43136 and works ✅

ostasevych · 2024-01-26T06:36:10Z

At first I was confused because I thought this report was for v28 (which doesn't have this problem ironically).

Pretty certain it's supposed to be davParsePermissions though a quick look would lead me to believe it was an issue in v27.1.5 too.

As far as I can tell, parseWebdavPermissions was the legacy/interim API in nextcloud-files early on, but switched in nextcloud-libraries/nextcloud-files#706

My wild guess is this got overlooked in NC27 because so much of the F2V changes are in NC28.

Preliminary (untested) fix in #43136.

are there any quick fixes?

Not really. This code gets compiled so it's not as easy to monkey patch (unlike the PHP).

While inspecting the code I also found reference to davParsePermissions function instead of unknown (or obsolete) parseWebdavPermissions.

Is that possible to share the compiled file(s) which fix the bug for quick and dirty patch? Not waiting until the new subrelease is issued?

solracsf · 2024-01-26T07:35:31Z

Is that possible to share the compiled file(s) which fix the bug for quick and dirty patch?

All files are at #43136

solracsf · 2024-01-26T13:45:56Z

Fixed by #43136

Gummikavalier · 2024-03-02T10:25:12Z

Confirmed working in Nextcloud 27.1.7. Thanks! ❤️

Githopp192 · 2024-03-03T14:24:10Z

confirm fixed with 27.1.7

Gummikavalier added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Jan 25, 2024

szaimen added the 27-feedback label Jan 25, 2024

solracsf changed the title ~~[Bug]: Deleted files view does not show any deleted files~~ [Bug]: v27 - Deleted files view (files_trashbin) does not show deleted files Jan 25, 2024

solracsf added feature: trashbin regression labels Jan 25, 2024

solracsf changed the title ~~[Bug]: v27 - Deleted files view (files_trashbin) does not show deleted files~~ [Bug]: v27.1.6 - Deleted files view (files_trashbin) does not show deleted files Jan 25, 2024

joshtrichards added a commit that referenced this issue Jan 25, 2024

fix(trashbin) Switch parseWebdavPermissions->davParsePermissions

ab1cde0

Fixes #43134 Signed-off-by: Josh <josh.t.richards@gmail.com>

joshtrichards mentioned this issue Jan 25, 2024

[stable27 ONLY] fix(trashbin) Switch parseWebdavPermissions->davParsePermissions #43136

Merged

5 tasks

nextcloud-command pushed a commit that referenced this issue Jan 25, 2024

fix(trashbin) Switch parseWebdavPermissions->davParsePermissions

b76f446

Fixes #43134 Signed-off-by: Josh <josh.t.richards@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

joshtrichards added the feature: files label Jan 25, 2024

joshtrichards linked a pull request Jan 25, 2024 that will close this issue

[stable27 ONLY] fix(trashbin) Switch parseWebdavPermissions->davParsePermissions #43136

Merged

5 tasks

solracsf added 3. to review Waiting for reviews and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 26, 2024

szaimen mentioned this issue Jan 26, 2024

downgrade back to 27.1.5 nextcloud/all-in-one#4119

Merged

solracsf closed this as completed Jan 26, 2024

solracsf added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 26, 2024

This comment was marked as resolved.

Sign in to view

skjnldsv mentioned this issue Jan 30, 2024

[Bug]: Deleted files won't appear in trashbin but are available on filesystem #43199

Closed

4 tasks

skjnldsv added this to the Nextcloud 27.1.7 milestone Jan 30, 2024

joshtrichards mentioned this issue Jan 30, 2024

trash bin does not work (empty) [Bug]: #43208

Closed

8 tasks

joshtrichards mentioned this issue Jan 31, 2024

[Bug]: Files/Folders not visible in trash bin when deleting from shared folder #41220

Closed

8 tasks

marcelklehr mentioned this issue Feb 1, 2024

[stable27] Roll back erroneous nextcloud/files update #43259

Merged

4 tasks

Pytal mentioned this issue Feb 5, 2024

[stable27] fix: Fix resolved nextcloud/files dep version and user quota parsing #43368

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: v27.1.6 - Deleted files view (`files_trashbin`) does not show deleted files #43134

[Bug]: v27.1.6 - Deleted files view (`files_trashbin`) does not show deleted files #43134

Gummikavalier commented Jan 25, 2024

Dennis1993 commented Jan 25, 2024

solracsf commented Jan 25, 2024

ostasevych commented Jan 25, 2024 •

edited

joshtrichards commented Jan 25, 2024 •

edited

solracsf commented Jan 26, 2024 •

edited

ostasevych commented Jan 26, 2024

solracsf commented Jan 26, 2024 •

edited

solracsf commented Jan 26, 2024

This comment was marked as resolved.

Gummikavalier commented Mar 2, 2024

Githopp192 commented Mar 3, 2024

[Bug]: v27.1.6 - Deleted files view (files_trashbin) does not show deleted files #43134

[Bug]: v27.1.6 - Deleted files view (files_trashbin) does not show deleted files #43134

Comments

Gummikavalier commented Jan 25, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

Steps to reproduce

Expected behavior

Installation method

Nextcloud Server version

Operating system

PHP engine version

Web server

Database engine version

Is this bug present after an update or on a fresh install?

Are you using the Nextcloud Server Encryption module?

What user-backends are you using?

Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

Dennis1993 commented Jan 25, 2024

solracsf commented Jan 25, 2024

ostasevych commented Jan 25, 2024 • edited

joshtrichards commented Jan 25, 2024 • edited

solracsf commented Jan 26, 2024 • edited

ostasevych commented Jan 26, 2024

solracsf commented Jan 26, 2024 • edited

solracsf commented Jan 26, 2024

This comment was marked as resolved.

Gummikavalier commented Mar 2, 2024

Githopp192 commented Mar 3, 2024

[Bug]: v27.1.6 - Deleted files view (`files_trashbin`) does not show deleted files #43134

[Bug]: v27.1.6 - Deleted files view (`files_trashbin`) does not show deleted files #43134

ostasevych commented Jan 25, 2024 •

edited

joshtrichards commented Jan 25, 2024 •

edited

solracsf commented Jan 26, 2024 •

edited

solracsf commented Jan 26, 2024 •

edited