Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27 ONLY] fix(trashbin) Switch parseWebdavPermissions->davParsePermissions #43136

Merged
merged 1 commit into from Jan 26, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Jan 25, 2024

Summary

parseWebdavPermissions was renamed to davParsePermissions in nextcloud-libraries/nextcloud-files#706 but the v27 trashbin was not adapted to it.

TODO

  • ...

Checklist

@joshtrichards
Copy link
Member Author

/compile amend

@joshtrichards joshtrichards changed the title fix(trashbin) Switch parseWebdavPermissions->davParsePermissions [stable27 ONLY] fix(trashbin) Switch parseWebdavPermissions->davParsePermissions Jan 25, 2024
Fixes #43134

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux requested review from skjnldsv, a team, Fenn-CS and sorbaugh and removed request for a team January 25, 2024 23:20
@susnux susnux added this to the Nextcloud 27.1.7 milestone Jan 25, 2024
Copy link
Member

@solracsf solracsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works ✅

@susnux susnux merged commit c7cf447 into stable27 Jan 26, 2024
38 of 39 checks passed
@susnux susnux deleted the jr/fix/trashbin-parse-files-api branch January 26, 2024 13:36
@sistemi-nv
Copy link

I'm a newbie with versioning and GIT, but from what I can understand this fix is still not merged to the Stable27 release.
Because this feature is fundamental for the NC platform, can I ask if it it is planned or possible to make a new 27 release with the fix?
Unluckily the 28 Release has still many bugs and regressions (i.e. Drag'n Drop still broken for Safari, #42366) and, in my experience, is still not usable ...
So I hope for a better 27 :)
Many thanks

@joshtrichards
Copy link
Member Author

@sistemi-nv Upcoming v27.1.7 along with the root cause fix via #43259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: v27.1.6 - Deleted files view (files_trashbin) does not show deleted files
5 participants