Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URLs in debugger-extension #15462

Merged
merged 1 commit into from Dec 4, 2023

Conversation

fcollonval
Copy link
Member

References

Wrong URLs are certainly the reason it failed to be published with a provenance certificate

Code changes

None

User-facing changes

Correct metadata on the NPM package for debugger-extension

Backwards-incompatible changes

None

@fcollonval fcollonval added this to the 3.6.x milestone Nov 30, 2023
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jtpio
Copy link
Member

jtpio commented Nov 30, 2023

Should this PR be linked in https://github.com/jupyterlab/jupyterlab/blob/main/RELEASE.md#postmortems for reference? Or will another issue be created to keep track of this for future reference?

@krassowski
Copy link
Member

I guess the added check in releaser makes it less crucial to have a postmortem added? I am going to merge this as-is because now the release-check is failing on all PRs, but if you still think postmortem issue is warranted we can still open and add one.

@krassowski krassowski merged commit 846a7b0 into jupyterlab:main Dec 4, 2023
61 of 81 checks passed
@krassowski
Copy link
Member

@meeseeksdev please backport to 4.0.x

@krassowski
Copy link
Member

@meeseeksdev please backport to 3.6.x

@jtpio
Copy link
Member

jtpio commented Dec 5, 2023

It's just so it's easier to find the link to this PR and the one in the releaser later if needed.

Opened #15493.

krassowski pushed a commit that referenced this pull request Dec 5, 2023
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
krassowski pushed a commit that referenced this pull request Dec 5, 2023
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
chisangajm3 added a commit to chisangajm3/jupyterlab that referenced this pull request Dec 18, 2023
* upstream/main: (7628 commits)
  Adopt ruff format (jupyterlab#15499)
  Bump scipy from 1.11.3 to 1.11.4 (jupyterlab#15474)
  [pre-commit.ci] pre-commit autoupdate (jupyterlab#15491)
  Pin `actions/labeler` to v4 to fix failing CI action (jupyterlab#15496)
  Add npm provenance issue to the list of release postmortems (jupyterlab#15493)
  Fix URLs in debugger-extension (jupyterlab#15462)
  Bump tj-actions/changed-files from 40.0.2 to 40.2.0 (jupyterlab#15471)
  Bump dessant/lock-threads from 4 to 5 (jupyterlab#15472)
  Bump pandas from 2.1.2 to 2.1.3 (jupyterlab#15473)
  Bump actions/github-script from 6 to 7 (jupyterlab#15470)
  Bump matplotlib from 3.7.2 to 3.8.2 (jupyterlab#15475)
  Bump rjsf to 5.13.4 (jupyterlab#15469)
  Don't play with the focus when handling focus event (jupyterlab#15408)
  [ci skip] Publish 4.1.0a4
  Updated light theme visited link colour to make text visible (jupyterlab#15406)
  Load custom CSS functionality and documentation (jupyterlab#14743)
  Added alt descriptions to a few icon and images (jupyterlab#15265)
  More robust galata/UI tests (jupyterlab#15355)
  Fix Shift + L not working in stdin (jupyterlab#15440)
  Upgrade releaser workflows for silent support (jupyterlab#15446)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants