-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify labels for user inputs and link dangling labels #15222
Clarify labels for user inputs and link dangling labels #15222
Conversation
Thanks for making a pull request to jupyterlab! |
Hey @krassowski, I'm having some trouble with failing integrity. I've run |
Hey @krassowski, @gabalafou. I've made the changes requested in #14987. Please let me know if any further changes are required. Thanks in advance. |
Hey @krassowski, I've had a bit of trouble with merge conflicts. I've fixed it and will update the snapshots after the pipeline has completed. |
Please update galata snapshots |
Galata snapshots updated. |
Hey @krassowski, I don't think the test failures are related to my code changes. Are there any further changes required for this PR? Thanks in advance. |
@m158261 the user facing changes make sense. great stuff! |
Thanks for the ping. Check Release and Pull Request Labeler failures are unrelated (tracked in #15462 and #15488 respectively) but the visual regression failures are as the only two failures for the main job are for modified snapshots:
and there are additional failures in documentation which are due to the need to update the extension manager snapshots there. Let's summon the bot: please update snapshots |
Documentation snapshots updated. |
Galata snapshots updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @m158261. Good to go if all green.
References
Meaningful labels are provided when user input is required. (WCAG Criteria 1.1.1 (A))). Text issue area # 6 in #9399
This is a more up to date implementation of #14987
Code changes
Placeholders and aria-labels have been added to input areas to provide greater screen reader accessibility.
User-facing changes
Placeholder text will now be more descriptive in input fields. Aria-labels have been added to some input fields to improve accessibility.
Backwards-incompatible changes
None