Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify labels for user inputs and link dangling labels #15222

Merged
merged 50 commits into from
Dec 15, 2023

Conversation

m158261
Copy link
Contributor

@m158261 m158261 commented Oct 4, 2023

References

Meaningful labels are provided when user input is required. (WCAG Criteria 1.1.1 (A))). Text issue area # 6 in #9399

This is a more up to date implementation of #14987

Code changes

Placeholders and aria-labels have been added to input areas to provide greater screen reader accessibility.

User-facing changes

Placeholder text will now be more descriptive in input fields. Aria-labels have been added to some input fields to improve accessibility.

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@m158261
Copy link
Contributor Author

m158261 commented Oct 11, 2023

Hey @krassowski, I'm having some trouble with failing integrity. I've run jlpm run integrity and pushed the results. Is there something I'm missing? Thanks in advance.

@github-actions github-actions bot added tag:CSS For general CSS related issues and pecadilloes Design System CSS labels Oct 13, 2023
@m158261
Copy link
Contributor Author

m158261 commented Oct 30, 2023

Hey @krassowski, @gabalafou. I've made the changes requested in #14987. Please let me know if any further changes are required. Thanks in advance.

@m158261
Copy link
Contributor Author

m158261 commented Nov 13, 2023

Hey @krassowski, I've had a bit of trouble with merge conflicts. I've fixed it and will update the snapshots after the pipeline has completed.

@m158261
Copy link
Contributor Author

m158261 commented Nov 13, 2023

Please update galata snapshots

Copy link
Contributor

Galata snapshots updated.

@m158261
Copy link
Contributor Author

m158261 commented Dec 4, 2023

Hey @krassowski, I don't think the test failures are related to my code changes. Are there any further changes required for this PR?

Thanks in advance.

@tonyfast
Copy link
Contributor

tonyfast commented Dec 4, 2023

@m158261 the user facing changes make sense. great stuff!

@krassowski
Copy link
Member

Thanks for the ping. Check Release and Pull Request Labeler failures are unrelated (tracked in #15462 and #15488 respectively) but the visual regression failures are as the only two failures for the main job are for modified snapshots:

    [jupyterlab] › test/jupyterlab/notebook-toolbar.test.ts:54:7 › Notebook Toolbar › Paste cell ───
    [jupyterlab] › test/jupyterlab/sidebars.test.ts:31:9 › Sidebars › Open Sidebar tab extensionmanager.main-view 

and there are additional failures in documentation which are due to the need to update the extension manager snapshots there.

Let's summon the bot: please update snapshots

Copy link
Contributor

github-actions bot commented Dec 4, 2023

Documentation snapshots updated.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

Galata snapshots updated.

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @m158261. Good to go if all green.

@krassowski krassowski merged commit 8eb902e into jupyterlab:main Dec 15, 2023
77 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet