Add test for repository.url #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first commit is expected to fail the test |
for more information, see https://pre-commit.ci
Linking to jupyterlab/jupyterlab#15462 for reference. |
|
Do you want me to wait for this PR before cutting a release next week? |
I won't have much time in the coming week. Feel free to skip this one if it is not ready. |
Thanks to you for finishing it up @blink1073 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When publishing JupyterLab with the NPM provenance feature, it failed because the package.json file was not defining a proper
repository.url. This adds a test for it incheck-npm-dist