More robust galata/UI tests #15355
Merged
More robust galata/UI tests #15355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
- do not check text immediately as the kernel needs to connect first - quality of life: instead of using nth selector, use proper category selectors which helps when testing with more kernels installed
This was referenced Nov 6, 2023
|
Some comments about the execution time huge variation you have encountered. I realized that lately by times to times the integration tests were executed with 2 workers instead of 1. This is nice but introduces discrepancies in documentation as in that case we end up with 2 |
|
Thanks! Should we merge these branches? It seems that we picked on different things I guess it would be good to see how it works together (and whether it does result in fully green tests on CI). Feel free to merge this branch (or specific commits) into your PR and then close this one. |
This was referenced Nov 22, 2023
|
@meeseeksdev please backport to 4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Nov 28, 2023
krassowski
added a commit
that referenced
this pull request
Nov 29, 2023
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
chisangajm3
added a commit
to chisangajm3/jupyterlab
that referenced
this pull request
Dec 18, 2023
* upstream/main: (7628 commits) Adopt ruff format (jupyterlab#15499) Bump scipy from 1.11.3 to 1.11.4 (jupyterlab#15474) [pre-commit.ci] pre-commit autoupdate (jupyterlab#15491) Pin `actions/labeler` to v4 to fix failing CI action (jupyterlab#15496) Add npm provenance issue to the list of release postmortems (jupyterlab#15493) Fix URLs in debugger-extension (jupyterlab#15462) Bump tj-actions/changed-files from 40.0.2 to 40.2.0 (jupyterlab#15471) Bump dessant/lock-threads from 4 to 5 (jupyterlab#15472) Bump pandas from 2.1.2 to 2.1.3 (jupyterlab#15473) Bump actions/github-script from 6 to 7 (jupyterlab#15470) Bump matplotlib from 3.7.2 to 3.8.2 (jupyterlab#15475) Bump rjsf to 5.13.4 (jupyterlab#15469) Don't play with the focus when handling focus event (jupyterlab#15408) [ci skip] Publish 4.1.0a4 Updated light theme visited link colour to make text visible (jupyterlab#15406) Load custom CSS functionality and documentation (jupyterlab#14743) Added alt descriptions to a few icon and images (jupyterlab#15265) More robust galata/UI tests (jupyterlab#15355) Fix Shift + L not working in stdin (jupyterlab#15440) Upgrade releaser workflows for silent support (jupyterlab#15446) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
When developing tests against #15330 and other issues I faced a problem where this code path would freeze the test in an infinite loop.
From an experiment on my fork it appears that this little change could cut the runtime for galata tests by
50%. From about 44 minutes down to about 22 minutes. Well, it appears unrelated, maybe just the runners were different because I also see the fast run (21 minutes) over in #15356 which does not include these changes.Code changes
Use playwright
getAttributeinstead of evaluation to get class name.User-facing changes
None
Backwards-incompatible changes
None