Fix update button in extension manager

[nbowditch-einblick]

References

Fixes #15316 Extension manager "Update to" button does not update extensions

Code changes

• Added missing extension_version parameter to the backend request when the "Update to ###" button is clicked in the extension manager.
  • This was done by adding options with a useVersion parameter to the install action on the front-end model. The request uses this value to set the extension_version property to the request body.
  • For the update button, we use entry.latest_version
  • Generic front-end action functions (eg performAction and onAction) now have an optional actionOptions parameter where additional parameters/specifications can be defined

User-facing changes

None

Backwards-incompatible changes

None

[jupyterlab-probot]

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[fcollonval]

Thanks a lot for working on this @nbowditch-einblick

I would like to propose a slightly different approach to pass directly the version as this is supported by the backend and may provide more flexibility.

[fcollonval]

Thanks @nbowditch-einblick

Would you be willing to add a test for this?

You can add it in that file: https://github.com/jupyterlab/jupyterlab/blob/b835dd9acc2a00e2ee12450b9bc2b988ad789bd3/galata/test/documentation/extension_manager.test.ts

Starting by duplicating that test:

jupyterlab/galata/test/documentation/extension_manager.test.ts

Line 54 in b835dd9

test('Sidebar', async ({ page }) => {

To fake an available update; you will need to set a newer version for one of the two packages in https://github.com/jupyterlab/jupyterlab/blob/main/galata/test/documentation/data/extensions.json

The test will look like:

   const waitRequest = page.waitForRequest(request => {
     if(request.method() !== 'POST' || !galata.Routes.extensions.test(request.url()) {
       return false;
     }
     const data = request.postDataJSON();
     return data.cmd === 'install' && data.extension_name === '...' && data.extension_version === '...';
   });
   await page.getByRole('button', { name: 'Update to <the fake version you set>'}).click();
   await waitRequest

[nbowditch-einblick]

@fcollonval - I added a test. It's passing, but I was having trouble getting other tests to pass, even before I added mine. My only concern is that if some of them are comparing screenshots, some of those might need to be updated now that I bumped the latest_version field in extensions.json (this will change the version label and add the update button). I would appreciate it if you could take a look and let me know if there's anything else that needs updating

[fcollonval]

Thanks a lot @nbowditch-einblick

Yes updating snapshots is hard as it depends on lots of OS specific config. Therefore we have a bot to do this properly 😉

bot please update documentation snapshots

[github-actions]

Documentation snapshots updated.

[krassowski]

Looks good to me. I will wait with merging to allow @fcollonval to take another look.

test/jupyterlab/kernel.test.ts:108:9 › Kernel › Console › Should not ask kernel when creating console from launcher failure is unrelated and is getting addressed in #15355

[nbowditch-einblick]

@krassowski - thanks for taking a look! please let me know if I can do anything to update the branch, I wasn't sure if you guys prefer me doing a merge or rebase, or just taking care of it yourselves before merging

[fcollonval]

Thanks @nbowditch-einblick !

Let's merge

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️

[krassowski]

@meeseeksdev please backport to 4.0.x