Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Shift + L not working in stdin #15440

Merged
merged 3 commits into from Nov 28, 2023
Merged

Conversation

krassowski
Copy link
Member

References

Fixes #15429

Code changes

Adds selector that should have been added before.

User-facing changes

When input box is focused, shift + l types "L" rather than toggling line numbers

Backwards-incompatible changes

None

This currently fails with:
  Expected string: "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"
  Received string: "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKMNOPQRSTUVWXYZ0123456789"
@krassowski krassowski added the bug label Nov 25, 2023
@krassowski krassowski added this to the 4.0.x milestone Nov 25, 2023
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski
Copy link
Member Author

One failure is relevant:

  4) [jupyterlab] › test/jupyterlab/shortcuts.test.ts:29:5 › Shortcuts must be unique ──────────────

    Error: expect(received).toEqual(expected) // deep equality

    - Array []
    + Array [
    +   "Skipping this default shortcut because it collides with another default shortcut. {command: viewmenu:line-numbering, keys: Array(1), selector: .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)}",
    + ]

Removing notebook:toggle-all-cell-line-numbers appears to fixing without regressions on the UI.

@krassowski
Copy link
Member Author

The failing visual regression test:
[jupyterlab] › test/jupyterlab/kernel.test.ts:108:9 › Kernel › Console › Should not ask kernel when creating console from launcher
is addressed by #15355

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krassowski

@fcollonval fcollonval merged commit 8405524 into jupyterlab:main Nov 28, 2023
76 of 79 checks passed
@fcollonval
Copy link
Member

@meeseeksdev please backport to 4.0.x

Copy link

lumberbot-app bot commented Nov 28, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 4.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 8405524535e761338e1b73ed93f8e7cda8d3d7fc
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #15440: Fix Shift + L not working in stdin'
  1. Push to a named branch:
git push YOURFORK 4.0.x:auto-backport-of-pr-15440-on-4.0.x
  1. Create a PR against branch 4.0.x, I would have named this PR:

"Backport PR #15440 on branch 4.0.x (Fix Shift + L not working in stdin)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

fcollonval pushed a commit to fcollonval/jupyterlab that referenced this pull request Nov 28, 2023
krassowski added a commit that referenced this pull request Nov 29, 2023
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
chisangajm3 added a commit to chisangajm3/jupyterlab that referenced this pull request Dec 18, 2023
* upstream/main: (7628 commits)
  Adopt ruff format (jupyterlab#15499)
  Bump scipy from 1.11.3 to 1.11.4 (jupyterlab#15474)
  [pre-commit.ci] pre-commit autoupdate (jupyterlab#15491)
  Pin `actions/labeler` to v4 to fix failing CI action (jupyterlab#15496)
  Add npm provenance issue to the list of release postmortems (jupyterlab#15493)
  Fix URLs in debugger-extension (jupyterlab#15462)
  Bump tj-actions/changed-files from 40.0.2 to 40.2.0 (jupyterlab#15471)
  Bump dessant/lock-threads from 4 to 5 (jupyterlab#15472)
  Bump pandas from 2.1.2 to 2.1.3 (jupyterlab#15473)
  Bump actions/github-script from 6 to 7 (jupyterlab#15470)
  Bump matplotlib from 3.7.2 to 3.8.2 (jupyterlab#15475)
  Bump rjsf to 5.13.4 (jupyterlab#15469)
  Don't play with the focus when handling focus event (jupyterlab#15408)
  [ci skip] Publish 4.1.0a4
  Updated light theme visited link colour to make text visible (jupyterlab#15406)
  Load custom CSS functionality and documentation (jupyterlab#14743)
  Added alt descriptions to a few icon and images (jupyterlab#15265)
  More robust galata/UI tests (jupyterlab#15355)
  Fix Shift + L not working in stdin (jupyterlab#15440)
  Upgrade releaser workflows for silent support (jupyterlab#15446)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User input clobbered by Keyboard Shortcuts in Lab
2 participants