New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix allow multiple audiences #10
Conversation
@csstaub Sorry for bothering you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the pull request!
@csstaub Thank you so much! |
Hey @shnmorimoto appreciate the fix provided over here. @csstaub I'm wondering if we could merge go-jose/go-jose@v2 branch with the latest from square/go-jose and then incorporate this fix in there as well so we could make use of it already? Or alternatively is the v3 still under development and not stable yet? Or is the README simply outdated?:) Appreciate your time in answering these! 🙇🏻 |
Confirming that the new behavior is correct per RFC 7519 Section 4.1.3:
(emphasis mine) |
Original issue is square/go-jose#286
And PR for v2 is square/go-jose#369
This PR allows multiple audiences.
Test result is below