jwt: use AnyAudience matching #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `Expected.Audience` field meant "all of these audiences must be present in the token." But that doesn't really make sense with the spec: https://datatracker.ietf.org/doc/html/rfc7519#section-4.1.3 Instead, rename the field to `AnyAudience` and changes its semantics to mean "there must be an intersection between this set and the set of audiences in the token."
beautifulentropy
approved these changes
Dec 12, 2023
Comment on lines
+92
to
+103
| if len(e.AnyAudience) != 0 { | ||
| var intersection bool | ||
| for _, v := range e.AnyAudience { | ||
| if c.Audience.Contains(v) { | ||
| intersection = true | ||
| break | ||
| } | ||
| } | ||
|
|
||
| if !intersection { | ||
| return ErrInvalidAudience | ||
| } |
There was a problem hiding this comment.
If we're on >= go1.21 we could also do:
if len(e.AnyAudience) != 0 && !slices.Contains(c.Audience, e.AnyAudience...) {
return ErrInvalidAudience
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
Expected.Audiencefield meant "all of these audiences must be present in the token." But that doesn't really make sense with the spec:https://datatracker.ietf.org/doc/html/rfc7519#section-4.1.3
Instead, rename the field to
AnyAudienceand changes its semantics to mean "there must be an intersection between this set and the set of audiences in the token."Re-land of #10 on the
main(v4) branch. Followup of #23 and #24. cc @shnmorimoto