Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Fix Allow multiple audiences #369

Closed

Conversation

shnmorimoto
Copy link

Related Issue

fixed #286

Description

  • allow any match for multiple audiences
  • currently go-jose requires all match for multiple audiences

@shnmorimoto
Copy link
Author

@csstaub Could you please review this PR? If the mention is wrong, I'm sorry.

I know that v3 repository already exists.
However, I think this is a bug fix, so I raised the PR to this repository.

@csstaub
Copy link
Collaborator

csstaub commented May 3, 2022

I can review this, but I don't have permissions on this repository anymore @shnmorimoto so it's not possible for me to do a release with this.

@csstaub
Copy link
Collaborator

csstaub commented May 3, 2022

If you raise this on the v3 repo I can merge it there and release it as a minor version

@shnmorimoto
Copy link
Author

@csstaub Thanks for replying!
I understood the current situation.

I raised PR to v3 repository.
go-jose/go-jose#10

@shnmorimoto
Copy link
Author

@mbyczkowski If the mention is wrong, I apologize.

This fix already had been merged on v3 repository.
But, it seems v2 version is still being used by many users and libraries.
So, if possible, could you merge this fix and release it on this repository?

@shnmorimoto
Copy link
Author

@mbyczkowski Sorry for bothering you.
Could you confirm this PR?

@RJNY
Copy link

RJNY commented Oct 3, 2022

Bump - I can confirm that we're also running into this issue on our team using v2. Would love to see this merged, especially since v2 is still considered the stable version

@Jthomas54
Copy link

Ditto, it is stopping the use of this package.

@csstaub
Copy link
Collaborator

csstaub commented Nov 17, 2022

Is this still an issue with v3: https://github.com/go-jose/go-jose ?

@csstaub
Copy link
Collaborator

csstaub commented Nov 17, 2022

The square/go-jose repo is the v2 version, v3 development moved over to go-jose/go-jose

@Jthomas54
Copy link

Looks like v3 will solve it but noticed that it is a dependency of github.com/auth0/go-jwt-middleware/v2/jwks so doubtful they will move to the "unstable" v3.

@csstaub
Copy link
Collaborator

csstaub commented Nov 17, 2022

There's a stable release for v3 now so I'd recommend to switch and submit new changes there. I don't have access to this repo anymore since I left Square. I'll see if we can update the README here.

@cpu cpu closed this Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants