feat(astro): Accept all vite-plugin options #15638
Conversation
Adds support for `unstable_sentryVitePluginOptions` which can be used to pass any valid vite-plugin option. Fixes getsentry#15601
| @@ -85,6 +85,7 @@ export const sentryAstro = (options: SentryOptions = {}): AstroIntegration => { | |||
| }, | |||
| }, | |||
| debug: options.debug ?? false, | |||
| ...unstable_sentryVitePluginOptions | |||
There was a problem hiding this comment.
In theory we need to spread this into all of the sub-options to be correct. Similar to how we do it here:
There was a problem hiding this comment.
Done: 15198e3 (#15638)
Btw. I'm not sure if the nextjs package spreads into sub-options correctly. It looks to me like at the end, it overwrites them anyway:
It looks like there is no test that would test a scenario with unstable_sentryWebpackPluginOptions set 🤔
There was a problem hiding this comment.
Oh I think you're right. Thanks for catching that. I'll fix that in a follow-up 👍
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #15638 Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
|
@angelikatyborska Thanks for contributing this! :) It's for the code snippet in the |
|
I opened a PR for the docs: getsentry/sentry-docs#13035 |
Adds support for
unstable_sentryVitePluginOptionswhich can be used to pass any valid vite-plugin option.Fixes #15601
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).Hello 👋 this is my first ever contribution in this repository. I hope I understood and followed all the contribution guides correctly. Please let me know if I need to fix something, add more tests, refactor something. Or feel free to push more commits yourself - whichever working style you prefer!
I tried to base my implementation of this feature for sentry/astro on the existing implementation for sentry/sveltekit, from where I copied for example the type comment.