fix(sveltekit): Correctly parse angle bracket type assertions for auto instrumentation #15578
+169
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Mar 4, 2025
| @@ -101,22 +103,80 @@ export async function canWrapLoad(id: string, debug: boolean): Promise<boolean> | |||
|
|
|||
| const code = (await fs.promises.readFile(id, 'utf8')).toString(); | |||
|
|
|||
| const mod = parseModule(code); | |||
| // Taken from recast's typescript parser config, minus the JSX plugin | |||
There was a problem hiding this comment.
if we're vendoring this in, we need to include the license. Would make sense to extract it to another file then.
There was a problem hiding this comment.
It's not a 1:1 copy but I agree, close enough to include the license and some more information. Thanks for the suggestion! c07db78
3 tasks
AbhiPrasad
approved these changes
Mar 4, 2025
Lms24
force-pushed
the
lms/fix-sveltekit-type-assertion
branch
from
ae5716b to
ed21615
Compare
Lms24
force-pushed
the
lms/fix-sveltekit-type-assertion
branch
from
ed21615 to
62f3b09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
magicastas a dependency of the Sveltekit SDKrecastand@babel/parser. Both dependencies were already transitive dependencies beforehand but with this, we just hoist it up a level.recastto use the TypeScript parser, just like it configures it. We can't directly use the recast typscript parser because its export is not compatible with ESMcloses #9318