feat(tanstackstart): Add @sentry/tanstackstart-react
package and make @sentry/tanstackstart
package a utility package
#15629
+375
−161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized thanks to TanStack/router#3607 (comment) that TanStack Start is gonna be a generic thing that supports multiple frameworks like React and Solid (maybe even more in the future).
This means that we should probably not publish the package for TanStack Start React as
@sentry/tanstackstart
. I thought about doing submodule exports like@sentry/tanstackstart/react
and@sentry/tanstackstart/solid
but that comes with a few (user-facing) drawbacks that I don't want to deal with:For the reasons above I decided to make the
@sentry/tanstackstart
package a utility package that we can use to host generic instrumentation helpers and publish an additional package called@sentry/tanstackstart-react
that contains the actual SDK. For now the utils package is empty but that will change in the future as we see fit.