internal/ethapi: handle blobs in API methods #28786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
reviewed
Jan 10, 2024
KillariDev
reviewed
Jan 11, 2024
holiman
reviewed
Jan 11, 2024
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
Co-authored-by: Martin HS <martin@swende.se>
|
I rebased to fix the merge conflicts. Note that this PR is in accord with the spec. As you can see |
|
I changed |
|
Triage discussion:
In a future PR, we should make these not fail: geth should be able to produce anything that is ethereum mainnet relevant/acceptable. |
karalabe
reviewed
Jan 16, 2024
karalabe
reviewed
Jan 16, 2024
karalabe
reviewed
Jan 16, 2024
karalabe
reviewed
Jan 16, 2024
holiman
reviewed
Jan 16, 2024
holiman
reviewed
Jan 16, 2024
Co-authored-by: Martin HS <martin@swende.se>
holiman
requested changes
Jan 17, 2024
This reverts commit 402313c.
Oops, fixed. |
holiman
approved these changes
Jan 17, 2024
Dergarcon
pushed a commit
to specialmechanisms/mev-geth-0x2mev
that referenced
this pull request
Jan 31, 2024
EIP-4844 adds a new transaction type for blobs. Users can submit such transactions via `eth_sendRawTransaction`. In this PR we refrain from adding support to `eth_sendTransaction` and in fact it will fail if the user passes in a blob hash. However since the chain can handle such transactions it makes sense to allow simulating them. E.g. an L2 operator should be able to simulate submitting a rollup blob and updating the L2 state. Most methods that take in a transaction object should recognize blobs. The change boils down to adding `blobVersionedHashes` and `maxFeePerBlobGas` to `TransactionArgs`. In summary: - `eth_sendTransaction`: will fail for blob txes - `eth_signTransaction`: will fail for blob txes The methods that sign txes does not, as of this PR, add support the for new EIP-4844 transaction types. Resuming the summary: - `eth_sendRawTransaction`: can send blob txes - `eth_fillTransaction`: will fill in a blob tx. Note: here we simply fill in normal transaction fields + possibly `maxFeePerBlobGas` when blobs are present. One can imagine a more elaborate set-up where users can submit blobs themselves and we fill in proofs and commitments and such. Left for future PRs if desired. - `eth_call`: can simulate blob messages - `eth_estimateGas`: blobs have no effect here. They have a separate unit of gas which is not tunable in the transaction.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-4844 adds a new transaction type for blobs. Users can submit such transactions via
eth_sendRawTransaction. In this PR we refrain from adding support toeth_sendTransactionand in fact it will fail if the user passes in a blob hash.However since the chain can handle such transactions it makes sense to allow simulating them. E.g. an L2 operator should be able to simulate submitting a rollup blob and updating the L2 state. Most methods that take in a transaction object should recognize blobs.The change boils down to adding
blobVersionedHashesandmaxFeePerBlobGastoTransactionArgs. In summary:eth_sendTransaction: will fail for blob txeseth_signTransaction: will fail for blob txesAs geth moves away from user-management responsibilities, the methods that sign txes will not support the new EIP-4844 transaction types. Please use
eth_sendRawTransactioninstead. Resuming the summary:eth_sendRawTransaction: can send blob txeseth_fillTransaction: will fill in a blob tx. Note: here we simply fill in normal transaction fields + possiblymaxFeePerBlobGaswhen blobs are present. One can imagine a more elaborate set-up where users can submit blobs themselves and we fill in proofs and commitments and such. Left for future PRs if desired.eth_call: can simulate blob messageseth_estimateGas: blobs have no effect here. They have a separate unit of gas which is not tunable in the transaction.