core: check for create blob txes #28779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
Jan 9, 2024
Comment on lines
+317
to
+319
| if msg.To == nil { | ||
| return ErrBlobTxCreate | ||
| } |
There was a problem hiding this comment.
func (tx *BlobTx) to() *common.Address { tmp := tx.To; return &tmp }
There was a problem hiding this comment.
So the to of a blob tx can never return nil, hence this check is not needed
There was a problem hiding this comment.
Ah, so, if someone creates a core.Message explicitly, and uses it to make a state transition, then this can happen. So the PR is good, from that perspective
rjl493456442
approved these changes
Jan 10, 2024
|
Since this case can only happen through RPC I think it makes sense to merge it together as part of #28786. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the spec: