New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphql: add withdrawals (EIP-4895) #400
Conversation
@shemnon please check this! |
@jangko, too |
e05e067
to
1c6d6ce
Compare
Ping, let's get this merged. |
Besu merged support for withdrawals matching the spec here. I think we can move forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple comment nits, otherwise looks good
schema.graphqls
Outdated
@@ -185,6 +187,18 @@ type Block { | |||
|
|||
"""Raw is the RLP encoding of the block.""" | |||
raw: Bytes! | |||
|
|||
""" | |||
WithdrawalsRoot is the keccak256 hash of the root of the trie of withdrawals in this block. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WithdrawalsRoot is the keccak256 hash of the root of the trie of withdrawals in this block. | |
WithdrawalsRoot is the keccak256 hash of the root of the trie of withdrawals in this block. |
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
implements withdrawals in graphql as per ethereum/execution-apis#400
implements withdrawals in graphql as per ethereum/execution-apis#400
implements withdrawals in graphql as per ethereum/execution-apis#400
implements withdrawals in graphql as per ethereum/execution-apis#400
implements withdrawals in graphql as per ethereum/execution-apis#400
Geth implementation: ethereum/go-ethereum#27072
Hive tests: ethereum/hive#764