Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: add withdrawals (EIP-4895) #400

Merged
merged 5 commits into from May 30, 2023

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Apr 8, 2023

Geth implementation: ethereum/go-ethereum#27072

Hive tests: ethereum/hive#764

@fjl
Copy link
Collaborator

fjl commented Apr 18, 2023

@shemnon please check this!

@fjl
Copy link
Collaborator

fjl commented Apr 18, 2023

@jangko, too

@holiman
Copy link
Contributor

holiman commented May 22, 2023

Ping, let's get this merged.

@s1na
Copy link
Contributor Author

s1na commented May 30, 2023

Besu merged support for withdrawals matching the spec here. I think we can move forward.

Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple comment nits, otherwise looks good

graphql.json Outdated Show resolved Hide resolved
graphql.json Outdated Show resolved Hide resolved
schema.graphqls Outdated
@@ -185,6 +187,18 @@ type Block {

"""Raw is the RLP encoding of the block."""
raw: Bytes!

"""
WithdrawalsRoot is the keccak256 hash of the root of the trie of withdrawals in this block.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
WithdrawalsRoot is the keccak256 hash of the root of the trie of withdrawals in this block.
WithdrawalsRoot is the keccak256 hash of the root of the trie of withdrawals in this block.

same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

s1na and others added 2 commits May 30, 2023 16:01
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
graphql.json Outdated Show resolved Hide resolved
@lightclient lightclient merged commit 3d627c9 into ethereum:main May 30, 2023
3 checks passed
holiman pushed a commit to ethereum/go-ethereum that referenced this pull request Jun 6, 2023
antonydenyer pushed a commit to antonydenyer/go-ethereum that referenced this pull request Jul 28, 2023
MoonShiesty pushed a commit to MoonShiesty/go-ethereum that referenced this pull request Aug 30, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
cyyber pushed a commit to cyyber/go-zond that referenced this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants