Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: test cases for withdrawals #764

Merged
merged 10 commits into from
Jun 6, 2023
Merged

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Apr 26, 2023

This PR adds test cases for withdrawals (schema: ethereum/execution-apis#400) as well as the general structure of blocks and type 2 txes. I took the existing PoW chain and extended it by one Shanghai block using this script: https://github.com/s1na/graphqltestgen.

@s1na
Copy link
Contributor Author

s1na commented Apr 26, 2023

Besu is failing to import the new block I generated. With Bonsai flag enabled it complains world state root mismatch, without that flag:

[f81057d3] 2023-04-26 16:30:32.402+00:00 | main | INFO  | BesuControllerBuilder | TTD difficulty is present, creating initial sync for PoS
[f81057d3] 2023-04-26 16:30:32.449+00:00 | main | INFO  | TransitionBesuControllerBuilder | TTD present, creating DefaultSynchronizer that stops propagating after finalization
[f81057d3] 2023-04-26 16:30:32.486+00:00 | main | INFO  | BlocksSubCommand | Importing from /chain.rlp
[5952d45b] 2023/04/26 16:30:32 checking address: 172.17.0.4:8545
[5952d45b] 2023/04/26 16:30:33 checking address: 172.17.0.4:8545
[f81057d3] 2023-04-26 16:30:34.644+00:00 | pool-10-thread-1 | WARN  | WithdrawalsValidator$AllowedWithdrawals | withdrawals must not be null when Withdrawals are activated
[f81057d3] 2023-04-26 16:30:34.649+00:00 | pool-10-thread-1 | INFO  | MainnetBlockValidator | Invalid block 33 (0x30e688f50392780a71899dcb4c35997f5c1d168cf90306d8e6919ea805097810)
[f81057d3] java.util.concurrent.CompletionException: java.lang.IllegalStateException: Invalid block at block number 33.
[f81057d3] 2023-04-26 16:30:34.683+00:00 | main | INFO  | Besu | Using jemalloc
EROR[04-26|18:30:34] API: could not start client              client=besu container=f81057d3 error="terminated unexpectedly"

@s1na
Copy link
Contributor Author

s1na commented May 9, 2023

Besu is failing to import the new block I generated.

This is fixed now. Now pending spec being merged.

@s1na
Copy link
Contributor Author

s1na commented Jun 6, 2023

@fjl PTAL

@fjl fjl merged commit 4215378 into ethereum:master Jun 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants