GraphQL Support for withdrawals #5496
Conversation
Add support for withdrawals in GraphQL, including needed changes to testing infrastructure for shanghai-era blocks. Also align existing adapters with graphql schema optionality. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
|
partial work to address ethereum/execution-apis#400 |
|
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
There was a problem hiding this comment.
I'm aware that it's a current issue we have but bringing into the context of this PR, the withdrawals fields should probably be hexa encoded as well as any other fields that report quantity.
We currently fail a few hive tests because we're a little out of spec regarding that.
There was a problem hiding this comment.
I have a followup for hex encoding that I'll post today.
For the record, the EIP was integer encoded, as were the initial hive tests. The execution tests transition to hex encoding was never subject to public discussion.
There was a problem hiding this comment.
Migration to strings - #5505 - Note that it builds off of this PR. It is only really a change to Scalars.java and most of the unit test vectors.
There was a problem hiding this comment.
For the record, the EIP was integer encoded, as were the initial hive tests.
The first geth implementation by Nick Johnson used hex-encoding. At some point half of the fields were changed to integer encoding (including hive tests for them) and half were kept as hex which was weird. I proposed on the specs repo to change it to hex to stay consistent also with JSON-RPC.
The execution tests transition to hex encoding was never subject to public discussion.
I took this comment ethereum/execution-apis#389 (comment) as an approval from the Besu side. I'm sorry if you thought there wasn't enough discussion around it. I'd like to make more changes to the hive tests, how do you prefer to discuss them?
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
# Conflicts: # CHANGELOG.md
Add support for withdrawals in GraphQL, including needed changes to testing infrastructure for shanghai-era blocks. Also align existing adapters with graphql schema optionality. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Add support for withdrawals in GraphQL, including needed changes to testing infrastructure for shanghai-era blocks. Also align existing adapters with graphql schema optionality. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Add support for withdrawals in GraphQL, including needed changes to testing infrastructure for shanghai-era blocks.
Also align existing adapters with graphql schema optionality.
PR description
Fixed Issue(s)