Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose initiator in navigation events #37085

Merged
merged 35 commits into from Feb 28, 2023
Merged

feat: expose initiator in navigation events #37085

merged 35 commits into from Feb 28, 2023

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Jan 31, 2023 •
edited

Description of Change

This exposes the initator of a navigation event, i.e. the frame which caused
the navigation to happen. This is a draft API just as a proof of concept,
because appending more positional arguments is a terrible idea.

This information allows distinguishing window.open from a parent frame causing a navigation vs. a child-initiated navigation. Ref #36949.

Checklist

Release Notes

Notes: Added initiator information to navigator events.

@nornagon nornagon added no-backport semver/minor backwards-compatible functionality labels Jan 31, 2023
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours api-review/requested 🗳 labels Jan 31, 2023
@nornagon nornagon mentioned this pull request Jan 31, 2023
Closed
3 tasks
@MarshallOfSound MarshallOfSound mentioned this pull request Feb 1, 2023
Merged
nornagon and others added 19 commits February 1, 2023 11:34
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 7, 2023
@nornagon nornagon marked this pull request as ready for review February 14, 2023 05:17
erickzhao
erickzhao approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@deepak1556 deepak1556 mentioned this pull request Feb 21, 2023
Merged
5 tasks
@itsananderson
Copy link
Contributor

API LGTM

ckerr
ckerr reviewed Feb 23, 2023
View reviewed changes
shell/browser/api/electron_api_web_frame_main.cc Outdated Show resolved Hide resolved
shell/browser/api/electron_api_web_contents.cc Outdated Show resolved Hide resolved
shell/browser/api/electron_api_web_contents.cc Outdated Show resolved Hide resolved
codebytere
codebytere approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@nornagon nornagon merged commit 3a5ae28 into main Feb 28, 2023
@nornagon nornagon deleted the navigate-initiator branch February 28, 2023 19:08
@release-clerk
Copy link

release-clerk bot commented Feb 28, 2023

Release Notes Persisted

Added initiator information to navigator events.

@miniak miniak mentioned this pull request Apr 12, 2023
Merged
@commit-lint commit-lint bot mentioned this pull request May 24, 2023
Open
@pushkin- pushkin- mentioned this pull request Jan 23, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr left review comments

@MarshallOfSound MarshallOfSound MarshallOfSound left review comments

@codebytere codebytere codebytere approved these changes

@erickzhao erickzhao erickzhao approved these changes

Assignees
No one assigned
Labels
api-review/approved ✅ no-backport semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nornagon @itsananderson @ckerr @codebytere @MarshallOfSound @erickzhao