Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: incorrect types for DidStartNavigation event #41086

Closed
3 tasks done
pushkin- opened this issue Jan 23, 2024 · 1 comment
Closed
3 tasks done

[Bug]: incorrect types for DidStartNavigation event #41086

pushkin- opened this issue Jan 23, 2024 · 1 comment
Labels

Comments

@pushkin-
Copy link

Preflight Checklist

Electron Version

28.1.0

What operating system are you using?

Windows

Operating System Version

Windows 10

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

expect correct types

Actual Behavior

My typing for DidStartNavigationEvent still says:

  interface DidStartNavigationEvent extends DOMEvent {
    url: string;
    isInPlace: boolean;
    isMainFrame: boolean;
    frameProcessId: number;
    frameRoutingId: number;
  }

docs indicate there should be a details property now on the event.
That pr was done in Electron 25.

Testcase Gist URL

No response

Additional Information

No response

@pushkin-
Copy link
Author

pushkin- commented Jan 23, 2024

misunderstood. Need to reference like Electron.Event<Electron.WebContentsDidStartNavigationEventParams>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant