feat: expose audio-state-changed on webContents
#37366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/minor
electron-cation
bot
added
api-review/requested 🗳
new-pr 🌱
deepak1556
reviewed
Feb 21, 2023
nornagon
reviewed
Feb 21, 2023
nornagon
reviewed
Feb 21, 2023
ckerr
reviewed
Feb 23, 2023
| * `event` Event | ||
| * `audible` boolean - Whether audio is currently playing. | ||
|
|
||
| Emitted when media becomes audible or inaudible. |
There was a problem hiding this comment.
Again a little imprecise for the same reason, but ... revising this in a way that still scans well is not obvious to me. For example this would be more correct but feels awkward:
Suggested change
| Emitted when media becomes audible or inaudible. | |
| Emitted when the first frame or child content starts playing, or when the last stops playing. |
If you have a third idea then let's consider that; otherwise, maybe OK as-is
There was a problem hiding this comment.
I updated the property description but i think this is probably more understandable as-is 🤔
codebytere
force-pushed
the
expose-audio-state-changed
branch
3 times, most recently
from
0475e00
to
b1125ed
Compare
codebytere
force-pushed
the
expose-audio-state-changed
branch
from
b1125ed
to
506fb05
Compare
deepak1556
approved these changes
Mar 3, 2023
electron-cation
bot
added
api-review/approved ✅
and removed
api-review/requested 🗳
labels
|
Release Notes Persisted
|
|
I was unable to backport this PR to "24-x-y" cleanly; |
trop
bot
added
needs-manual-bp/24-x-y
and removed
target/24-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #37352.
Exposes and documents the
audio-state-changedevent onwebContents. We previously emitted it, but it was a private and undocumented event. This documents and removes the-prefix.Checklist
npm testpassesRelease Notes
Notes: Exposes the
audio-state-changedevent onwebContents.