Replace calls to Method.GetCurrentMethod().Name with nameof()
#1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That reduce places which marked as trimmer unfriendly. Even if `Method.CurrentMethod().Name` will work after trimming, but tooling cannot decide that in generic cases, see: dotnet/runtime#53242 At this point I would like to replace formatting primitives with `$""` if possible, since that allow Rolsyn manually build constant string. Also enabled Trim Analyzer on the build, so all trim warnings can be gradually removed after proper annotations, or other work done. /cc @Wraith2
Wraith2
reviewed
Mar 5, 2023
| @@ -30,7 +30,7 @@ static LocalAppContextSwitches() | |||
| catch (Exception e) | |||
| { | |||
| // Don't throw an exception for an invalid config file | |||
| SqlClientEventSource.Log.TryTraceEvent("<sc.{0}.{1}|INFO>: {2}", TypeName, MethodBase.GetCurrentMethod().Name, e); | |||
| SqlClientEventSource.Log.TryTraceEvent("<sc.{0}.{1}|INFO>: {2}", TypeName, "..ctor", e); | |||
There was a problem hiding this comment.
shouldn't this be .cctor for a static constructor?
There was a problem hiding this comment.
Also, can you inline the TypeName, it's a nameof in a variable which is a bit pointless when it's single use.
Wraith2
approved these changes
Mar 5, 2023
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/LocalAppContextSwitches.cs
Outdated
Show resolved
Hide resolved
DavoudEshtehari
added
➕ Code Health
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1943 +/- ##
==========================================
- Coverage 71.53% 69.69% -1.84%
==========================================
Files 306 306
Lines 61841 61563 -278
==========================================
- Hits 44235 42909 -1326
- Misses 17606 18654 +1048
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 42 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…lAppContextSwitches.cs
DavoudEshtehari
approved these changes
Mar 20, 2023
lcheunglci
approved these changes
Mar 21, 2023
|
The changes looks good to me. Thanks @kant2002 for your contributions |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That reduce places which marked as trimmer unfriendly. Even if
Method.CurrentMethod().Namewill work after trimming, but tooling cannot decide that in generic cases, see: dotnet/runtime#53242 At this point I would like to replace formatting primitives with$""if possible, since that allow Rolsyn build constant string for us at compile time.Also enabled Trim Analyzer on the build, so all trim warnings can be gradually removed after proper annotations, or other work done.
/cc @Wraith2