Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace calls to Method.GetCurrentMethod().Name with nameof() #1943

Merged
merged 4 commits into from Mar 21, 2023
Merged

Replace calls to Method.GetCurrentMethod().Name with nameof() #1943

merged 4 commits into from Mar 21, 2023

Commits on Mar 5, 2023

  1. Replace calls to Method.GetCurrentMethod().Name with nameof() 

    That reduce places which marked as trimmer unfriendly. Even if `Method.CurrentMethod().Name` will work after trimming, but tooling cannot decide that in generic cases, see: dotnet/runtime#53242
At this point I would like to replace formatting primitives with `$""` if possible, since that allow Rolsyn manually build constant string.

Also enabled Trim Analyzer on the build, so all trim warnings can be gradually removed after proper annotations, or other work done.

/cc @Wraith2
    @kant2002
    kant2002 committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    4609ba3 View commit details
    Browse the repository at this point in the history

  2. Apply PR suggestions

    @kant2002
    kant2002 committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    f547da7 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Remove unnecessary usings

    @DavoudEshtehari
    DavoudEshtehari committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    00940af View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Update src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Loca… 

    …lAppContextSwitches.cs
    @DavoudEshtehari
    DavoudEshtehari committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    7d55d47 View commit details
    Browse the repository at this point in the history