Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation | Release Notes 5.2.0-preview1 #2009

Merged
merged 39 commits into from
Apr 21, 2023

Conversation

Kaur-Parminder
Copy link
Contributor

Release Notes 5.2.0-preview1

@DavoudEshtehari DavoudEshtehari added the 📃 Documentation Use this label for any documentation changes label Apr 19, 2023
@DavoudEshtehari DavoudEshtehari added this to the 5.2.0-preview1 milestone Apr 19, 2023
Copy link
Member

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Use past tense verbs.
  • Combine general enhancements under the common title "Code health improvements".

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Kaur-Parminder and others added 2 commits April 19, 2023 13:16
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 95.16% and project coverage change: -6.04 ⚠️

Comparison is base (a6e7e0d) 70.58% compared to head (c7ee37d) 64.55%.

❗ Current head c7ee37d differs from pull request most recent head e1f6d3c. Consider uploading reports for the commit e1f6d3c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2009      +/-   ##
==========================================
- Coverage   70.58%   64.55%   -6.04%     
==========================================
  Files         306      306              
  Lines       61722    61800      +78     
==========================================
- Hits        43569    39897    -3672     
- Misses      18153    21903    +3750     
Flag Coverage Δ
addons 0.00% <ø> (-92.89%) ⬇️
netcore 67.16% <100.00%> (-6.20%) ⬇️
netfx 63.63% <92.50%> (-5.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs 53.05% <70.00%> (-20.76%) ⬇️
...netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs 60.93% <100.00%> (-22.62%) ⬇️
...core/src/Microsoft/Data/SqlClient/SqlConnection.cs 77.14% <100.00%> (-1.73%) ⬇️
.../netfx/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs 69.00% <100.00%> (-1.45%) ⬇️
...etfx/src/Microsoft/Data/SqlClient/SqlConnection.cs 59.41% <100.00%> (-0.01%) ⬇️

... and 54 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs #1848 and #1866 are part of this release that should be added to the release note.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Kaur-Parminder and others added 2 commits April 20, 2023 13:55
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
release-notes/5.2/5.2.0-preview1.md Outdated Show resolved Hide resolved
release-notes/5.2/5.2.0-preview1.md Outdated Show resolved Hide resolved
release-notes/5.2/5.2.0.md Outdated Show resolved Hide resolved
release-notes/5.2/README.md Outdated Show resolved Hide resolved
@Kaur-Parminder Kaur-Parminder marked this pull request as ready for review April 20, 2023 23:03
Copy link
Member

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the common notes are identical in all the files.
You can use the preview tool in VS to verify the output before pushing it.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@DavoudEshtehari DavoudEshtehari merged commit 4657311 into dotnet:main Apr 21, 2023
117 of 131 checks passed
@Kaur-Parminder Kaur-Parminder deleted the RNotes-52p1 branch April 21, 2023 21:01
kant2002 pushed a commit to kant2002/SqlClient that referenced this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📃 Documentation Use this label for any documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants