chore: replace atty with is-terminal

[jcgruenhage]

atty is unmaintained and has a potential unaligned read. See https://github.com/rustsec/advisory-db/blob/main/crates/atty/RUSTSEC-2021-0145.md.

is-terminal is a replacement based on atty, with the soundness issue fixed and an (IMO) nicer to use API, mirroring what's available in the std lib on nightly with std::io::IsTerminal.

[lemmih]

@jcgruenhage The is-terminate crate somehow requires nightly when targeting wasi32. Do you know why?

[jcgruenhage]

No clue, sorry. What's the error message you're getting? As far as I can tell, is-terminal should work one any Rust version >= 1.48.0 and not require nightly.

[lemmih]

No clue, sorry. What's the error message you're getting? As far as I can tell, is-terminal should work one any Rust version >= 1.48.0 and not require nightly.

It might use libc with a different set of features which then cause trouble in the errno crate. Will investigate.

[nbarrios1337]

@jcgruenhage The is-terminate crate somehow requires nightly when targeting wasi32. Do you know why?

Did some digging on the wasi32 compilation error:

• is-terminal v0.4.3 depends on rustix v0.36.8, leading to a transitive dependency on errno v0.2.8, resulting in this PR's CI error.
• errno recently merged a PR that removed use of feature(thread_local) and released v0.3 that encapsulates that change among others
• rustix recently merged a PR that bumps its errno dependency to v0.3.0

To summarize what this PR needs:

• is-terminal would have to update its rustix dependency once rustix releases a version with the errno version bump change
• This PR would then need to update to that is-terminal version in order for it to not fail on the aforementioned CI error

[bgianfo]

To summarize what this PR needs:

• is-terminal would have to update its rustix dependency once rustix releases a version with the errno version bump change
• This PR would then need to update to that is-terminal version in order for it to not fail on the aforementioned CI error

Looks like is-terminal merged an update to it's rustix version, but hasn't quite cut a new release yet. sunfishcode/is-terminal#20

[nickelc]

A new version has just been released.
https://crates.io/crates/is-terminal/0.4.6

[jcgruenhage]

@nickelc thanks for the notification, I've pulled in that release and rebased on latest master. Hopefully that should be merge-able now?

[nbarrios1337]

Looks like the csv crate updated their MSRV to rustc 1.60 as of csv v1.2.0. From my understanding, criterion would either need to (a) Bump its own MSRV to 1.60 or (b) set a stricter version requirement for its csv dependency (i.e. ~1.1 in the Cargo.toml)

[lemmih]

Looks like the csv crate updated their MSRV to rustc 1.60 as of csv v1.2.0. From my understanding, criterion would either need to (a) Bump its own MSRV to 1.60 or (b) set a stricter version requirement for its csv dependency (i.e. ~1.1 in the Cargo.toml)

Bumping the MSRV would be the easiest solution. Anyone up for that task?

[nbarrios1337]

PR made to bump the MSRV: #665

[lemmih]

Hmm, it appears that rustix does not support wasm when using stable rust.

[sunfishcode]

Ah, that's a bug in rustix. I've submitted bytecodealliance/rustix#589 to fix it.

[sunfishcode]

The wasm32-wasi build on stable Rust is now fixed in rustix 0.37.7 and 0.36.12.

[lemmih]

The wasm32-wasi build on stable Rust is now fixed in rustix 0.37.7 and 0.36.12.

Nice!

[nbarrios1337]

Perhaps a small commit for the CI to rerun is unpinning the tempfile dep? I believe it was pinned in #665 because of the same rustix bug.

[jcgruenhage]

I just re-run the CI by rebasing and force-pushing instead. CI seems happy now!

[dianpopa]

It s great to see this merged! Is it possible to also create an official tag for the change? (I expect 0.4.1)?
We use this in Firecracker for benchmarking our versionize functionality.
Thanks!

[lemmih]

New releases can only be made by @bheisler.

[dianpopa]

@bheisler can you please release a new version that includes this fix? Thanks!

[lemmih]

@bheisler can you please release a new version that includes this fix? Thanks!

I have permission to release a new version. Will need to review this PR first (#679) and then update the CHANGELOG. A new is coming but it'll come faster with help.