Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo deny to CI #263

Merged
merged 1 commit into from Jan 10, 2023
Merged

Conversation

iamjpotts
Copy link
Contributor

@iamjpotts iamjpotts commented Dec 29, 2022

  1. Locks the list of allowed licenses to the current set of dependency licenses
  2. Surfaces two advisories as warnings (comments added to deny.yml for both)
  3. Surfaces duplicate versions of the same dependency as warnings (comments added to deny.yml for both)

One of the advisories is for atty a dependency of criterion and tracked in an issue in the criterion repo.

@vmx
Copy link
Member

vmx commented Jan 9, 2023

Thanks for your PR! I've just merged a PR that fixes the Clippy errors on CI. Could you please rebase your PR? I think it's a good idea and we should give it a try. If it turns out a too big burden, we can always remove it again. Also thanks for adding the exception for the current problems, so that we can start in a "green" state and work from there.

@iamjpotts iamjpotts force-pushed the 20221228-cargo-deny branch 2 times, most recently from 73bc7e8 to 3e46cc8 Compare January 9, 2023 18:40
@iamjpotts
Copy link
Contributor Author

Thanks for your PR! I've just merged a PR that fixes the Clippy errors on CI. Could you please rebase your PR? I think it's a good idea and we should give it a try. If it turns out a too big burden, we can always remove it again. Also thanks for adding the exception for the current problems, so that we can start in a "green" state and work from there.

@vmx

Rebased, and made a change to the workflow job to how it installs cargo-deny.

.github/workflows/build.yml Outdated Show resolved Hide resolved
@iamjpotts iamjpotts force-pushed the 20221228-cargo-deny branch 2 times, most recently from c2f0f8b to 3ecf51d Compare January 9, 2023 19:11
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spending so much time on this!

@vmx vmx merged commit 88ad64e into multiformats:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants