Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove atty dependency #33

Closed
3 tasks done
andrewmwells-amazon opened this issue May 9, 2023 · 1 comment · Fixed by #93
Closed
3 tasks done

Remove atty dependency #33

andrewmwells-amazon opened this issue May 9, 2023 · 1 comment · Fixed by #93
Labels
internal-improvement Refactoring, performance improvement, or other non-breaking change

Comments

@andrewmwells-amazon
Copy link
Contributor

Before opening, please confirm:

Bug Category

Other

Describe the bug

Our (transitive, through criterion) atty dependency is outdated. The version used has a security vulnerability. We aren't exposed to it but once a new version of criterion is released we should upgrade so we don't have the transitive atty dependency.

Expected behavior

No response

Reproduction steps

No response

Code Snippet

No response

Log output

No response

Additional configuration

No response

Operating System

No response

Additional information and screenshots

No response
@anwarmamat anwarmamat added bug Something isn't working pending-review Awaiting review by the core team labels May 22, 2023
@john-h-kastner-aws
Copy link
Contributor

For reference bheisler/criterion.rs#628 updated the dependency in criterion. Comments by a maintainer at the end of that thread indicate that we can expect a release on a reasonable timeline.

@anwarmamat anwarmamat removed the bug Something isn't working label May 24, 2023
john-h-kastner-aws added a commit that referenced this issue May 30, 2023
@john-h-kastner-aws
Update criterion to version 0.5
0ce6c10 
This removes the dependency on `atty` fixing #33.
@john-h-kastner-aws john-h-kastner-aws mentioned this issue May 30, 2023
Merged
@john-h-kastner-aws john-h-kastner-aws linked a pull request May 30, 2023 that will close this issue
Update criterion to version 0.5 #93
Merged
john-h-kastner-aws added a commit that referenced this issue May 30, 2023
@john-h-kastner-aws
Update criterion to version 0.5 (#93)
b5c463e 
This removes the dependency on `atty` fixing #33.
@khieta khieta added internal-improvement Refactoring, performance improvement, or other non-breaking change and removed pending-review Awaiting review by the core team labels Jun 6, 2023
john-h-kastner-aws added a commit that referenced this issue Jul 25, 2023
@john-h-kastner-aws
Update criterion to version 0.5 (#93)
a6ca5b2 
This removes the dependency on `atty` fixing #33.

(cherry picked from commit b5c463e)
cdisselkoen pushed a commit that referenced this issue Aug 11, 2023
@john-h-kastner-aws @cdisselkoen
Update criterion to version 0.5 (#93)
96fbbc7 
This removes the dependency on `atty` fixing #33.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal-improvement Refactoring, performance improvement, or other non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update criterion to version 0.5 cedar-policy/cedar
4 participants
@khieta @anwarmamat @andrewmwells-amazon @john-h-kastner-aws