Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upstream] atty crate has unsoundness bug #3284

Closed
roypat opened this issue Nov 22, 2022 · 3 comments · Fixed by #3799
Closed

[Upstream] atty crate has unsoundness bug #3284

roypat opened this issue Nov 22, 2022 · 3 comments · Fixed by #3799
Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled `

Comments

@roypat
Copy link
Contributor

roypat commented Nov 22, 2022

This issues tracks the effort of our upstream dependencies to resolve RUSTSEC-2021-0145. We transitively depend on atty through criterion, where the fix is implemented bheisler/criterion.rs#628. Once this PR is merged, we can revert #3283 and properly fix the warning by updating criterion.
@zulinx86
Copy link
Contributor

Since we backported the fix in #3282 on v1.1, we need to revert this on v1.1 as well.
Let me leave this comment not to forget it.

@roypat
Copy link
Contributor Author

roypat commented Nov 24, 2022

Same thing for 1.0 (via #3288)

@JonathanWoollett-Light JonathanWoollett-Light added the Status: Blocked Indicates that an issue or pull request cannot currently be worked on label Dec 7, 2022
@roypat
Copy link
Contributor Author

roypat commented Apr 5, 2023

The PR fixing this in criterion.rs just got merged!

@roypat roypat added Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` and removed Status: Blocked Indicates that an issue or pull request cannot currently be worked on labels Apr 5, 2023
@dianpopa dianpopa mentioned this issue Apr 10, 2023
Merged
@zulinx86 zulinx86 mentioned this issue Jun 6, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled `
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(test): Remove ignorance of RUSTSEC-2021-0145 zulinx86/firecracker
3 participants
@JonathanWoollett-Light @zulinx86 @roypat