New rule S6507: Blocks should not be synchronized on local variables #6854
Conversation
antonioaversa
changed the title
antonioaversa
added
Area: C#
antonioaversa
force-pushed
the
Antonio/S2445-move-local-variables-to-S6507
branch
from
053f7a3
to
dfae8e0
Compare
| } | ||
| } | ||
|
|
||
| void ReportIssue(string message) => |
There was a problem hiding this comment.
Nitpick: I'd keep this method and add the Rule as a parameter because it's still shorter.
There was a problem hiding this comment.
I agree. Otherwise LocalVariableRule doesn't need to be reported via format string and the full message can be in the rule (using string.Format directly there)
Not required for the release.
antonioaversa
force-pushed
the
Antonio/S2445-move-local-variables-to-S6507
branch
from
441f077
to
032c6b2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
| <ul> | ||
| <li> <a href="https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/statements/lock">Lock Statement</a> - lock statement - ensure | ||
| exclusive access to a shared resource </li> | ||
| <li> <a href="https://cwe.mitre.org/data/definitions/412">MITRE, CWE-412</a> - Unrestricted Externally Accessible Lock </li> |
There was a problem hiding this comment.
Not relevant for this clone of the rule - can be fixed in RSPEC later, not in this release
| <li> <a href="https://cwe.mitre.org/data/definitions/412">MITRE, CWE-412</a> - Unrestricted Externally Accessible Lock </li> |
| } | ||
| } | ||
|
|
||
| void ReportIssue(string message) => |
There was a problem hiding this comment.
I agree. Otherwise LocalVariableRule doesn't need to be reported via format string and the full message can be in the rule (using string.Format directly there)
Not required for the release.
Implements new rule with "lock on local variable" check moved from S2445
To fix false positives introduced by #6701
Draft, to be merged together with RSPEC: SonarSource/rspec#1608