Create rule S6507 with "lock on local variable" check moved from S2445 #1608
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
antonioaversa
changed the title
|
"Build and Deploy / build-and-deploy (push)" GitHub check failures is not related to this PR, and is already present on master: https://github.com/SonarSource/rspec/actions/runs/4319582662/jobs/7538926037#step:3:132 |
rules/S6507/comments-and-links.adoc
Outdated
| === is related to: S2445 | ||
|
|
||
| === on 3 Mar 2022, 10:46:00 Antonio Aversa wrote: | ||
| Rule spawn from the C# version of S2445, due to this branch of the rule generating a lot of FPs. |
There was a problem hiding this comment.
Nitpick: spawn -> derived
| === is related to: S2445 | ||
|
|
||
| === on 3 Mar 2022, 10:46:00 Antonio Aversa wrote: | ||
| Rule derived from the C# version of S2445, due to this branch of the rule generating a lot of FPs. |
There was a problem hiding this comment.
Maybe explain a bit more why this decision was taken.
It's not only for the FPs - this branch of the rule is still useful if indeed a local variable var local = new Object() for example is used, right?
There was a problem hiding this comment.
Yes, added a couple of paragraphs in my comment, with more details.
rules/S6507/csharp/rule.adoc
Outdated
| ---- | ||
| private void DoSomething() | ||
| { | ||
| object local; |
There was a problem hiding this comment.
| object local; | |
| object local = new object(); |
should not compile otherwise.
|
SonarQube Quality Gate for 'rspec-frontend'
|
|
SonarQube Quality Gate for 'rspec-tools'
|
You can preview this rule here (updated a few minutes after each push).
Kept in draft, to be merged together with SonarSource/sonar-dotnet#6854