New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Rule S2445: Blocks should be synchronized on read-only fields #6701
Labels
Projects
Milestone
Comments
zsolt-kolbay-sonarsource
added
Type: New Feature
This hasn't been here before.
Area: C#
C# rules related issues.
labels
Feb 2, 2023
We need to rename the rule to C# syntax |
antonioaversa
changed the title
New Rule S2445: Blocks should be synchronized on "private final" fields
New Rule S2445: Blocks should be synchronized on "private readonly" fields
Feb 13, 2023
This was referenced Feb 13, 2023
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
Feb 22, 2023
github-actions
bot
moved this from Review approved
to Review in progress
in Best Kanban
Feb 22, 2023
antonioaversa
changed the title
New Rule S2445: Blocks should be synchronized on "private readonly" fields
New Rule S2445: Blocks should be synchronized on read-only fields
Feb 27, 2023
This was referenced Feb 27, 2023
Results of Peach Validation: many FP found on "locking of local variables" for "advanced" synchronization scenarios such as:
A new rule S6507 has been created (#6854), to extract the offending check from S2445. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Implement S2445 for C#
The check for
private
has been removed, following the outcome of the discussion here, summarized here.The text was updated successfully, but these errors were encountered: