Fix S2094 FP: type specifications, attributes and conditional compilation #6784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsolt-kolbay-sonarsource
requested review from
antonioaversa
and removed request for
antonioaversa
|
(.NET ITs failed due to a nuget failure, I retried to check if it's intermittent stuff) |
analyzers/src/SonarAnalyzer.Common/Rules/ClassShouldNotBeEmptyBase.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Rules/ClassShouldNotBeEmptyBase.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ClassShouldNotBeEmpty.Inheritance.cs
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ClassShouldNotBeEmpty.cs
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ClassShouldNotBeEmpty.cs
Show resolved
Hide resolved
andrei-epure-sonarsource
requested changes
Feb 24, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
SonarCloud Quality Gate failed. |
|
The The S2743 code smell is difficult to overcome because of the facade. It could be fixed with a default interface implementation, but the target runtime doesn't support this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6704
Exceptions were added for the following test cases:
System.Attributeor implements theIActionResultinterface in ASP.NETThe rule message was changed to be similar to Java and other languages covering S2094.