Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S2094 FP: type specifications, attributes and conditional compilation #6784

Merged
merged 5 commits into from Feb 24, 2023
Merged

Fix S2094 FP: type specifications, attributes and conditional compilation #6784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
993271b
Add more exceptions to test cases
zsolt-kolbay-sonarsource Feb 23, 2023
4ad4042
Update Sarif files
zsolt-kolbay-sonarsource Feb 23, 2023
11a7f52
Add more test cases refactor base class
zsolt-kolbay-sonarsource Feb 24, 2023
77cf181
Update RSPEC
zsolt-kolbay-sonarsource Feb 24, 2023
d5b1d89
refactor to reduce duplication
andrei-epure-sonarsource Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ers/its/expected/Ember-MM/Ember.Plugins-{9496C697-5AFD-4813-AEDC-AF33FACEADF0}-S2094.json
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
"issues": [
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\Ember-MM\Ember.Plugins\PluginActionContext.cs",
"region": {
Expand Down
14 changes: 7 additions & 7 deletions analyzers/its/expected/Net5/Net5--net5.0-S2094.json
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
"issues": [
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\Net5\Net5\ModuleInitializers.cs",
"region": {
Expand All @@ -15,7 +15,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\Net5\Net5\ParameterValidation.cs",
"region": {
Expand All @@ -28,7 +28,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\Net5\Net5\S2330.cs",
"region": {
Expand All @@ -41,7 +41,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\Net5\Net5\S3240.cs",
"region": {
Expand All @@ -54,7 +54,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\Net5\Net5\S3247.cs",
"region": {
Expand All @@ -67,7 +67,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\Net5\Net5\S3453.cs",
"region": {
Expand All @@ -80,7 +80,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\Net5\Net5\StaticLambdas.cs",
"region": {
Expand Down
2 changes: 1 addition & 1 deletion analyzers/its/expected/Net7/Net7--net7.0-S2094.json
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
"issues": [
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\Net7\Net7\features\WarningWave7.cs",
"region": {
Expand Down
30 changes: 15 additions & 15 deletions analyzers/its/expected/akka.net/Akka--netstandard2.0-S2094.json
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
"issues": [
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka\Actor\ActorSelection.cs",
"region": {
Expand All @@ -15,7 +15,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka\Actor\FSM.cs",
"region": {
Expand All @@ -28,7 +28,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka\Event\LoggerInitialized.cs",
"region": {
Expand All @@ -41,7 +41,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka\Event\Logging.cs",
"region": {
Expand All @@ -54,7 +54,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka\IO\Dns.cs",
"region": {
Expand All @@ -67,7 +67,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka\IO\Inet.cs",
"region": {
Expand All @@ -80,7 +80,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka\IO\Tcp.cs",
"region": {
Expand All @@ -93,7 +93,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka\IO\Tcp.cs",
"region": {
Expand All @@ -106,7 +106,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka\IO\Tcp.cs",
"region": {
Expand All @@ -119,7 +119,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka\IO\Udp.cs",
"region": {
Expand All @@ -132,7 +132,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka\IO\Udp.cs",
"region": {
Expand All @@ -145,7 +145,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka\IO\UdpConnected.cs",
"region": {
Expand All @@ -158,7 +158,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka\Pattern\BackoffOptions.cs",
"region": {
Expand All @@ -171,7 +171,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka\Routing\Listeners.cs",
"region": {
Expand All @@ -184,7 +184,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka\Routing\RouterMsg.cs",
"region": {
Expand Down
4 changes: 2 additions & 2 deletions analyzers/its/expected/akka.net/Akka.Benchmarks--netcoreapp3.1-S2094.json
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
"issues": [
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\benchmark\Akka.Benchmarks\IO\TcpOperationsBenchmarks.cs",
"region": {
Expand All @@ -15,7 +15,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\benchmark\Akka.Benchmarks\IO\TcpOperationsBenchmarks.cs",
"region": {
Expand Down
4 changes: 2 additions & 2 deletions analyzers/its/expected/akka.net/Akka.Cluster--netstandard2.0-S2094.json
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
"issues": [
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster\ClusterDaemon.cs",
"region": {
Expand All @@ -15,7 +15,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster\ClusterHeartbeat.cs",
"region": {
Expand Down
8 changes: 4 additions & 4 deletions analyzers/its/expected/akka.net/Akka.DI.TestKit--netstandard2.0-S2094.json
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
"issues": [
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\contrib\dependencyinjection\Akka.DI.TestKit\DiResolverSpec.cs",
"region": {
Expand All @@ -15,7 +15,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\contrib\dependencyinjection\Akka.DI.TestKit\DiResolverSpec.cs",
"region": {
Expand All @@ -28,7 +28,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\contrib\dependencyinjection\Akka.DI.TestKit\DiResolverSpec.cs",
"region": {
Expand All @@ -41,7 +41,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\contrib\dependencyinjection\Akka.DI.TestKit\DiResolverSpec.cs",
"region": {
Expand Down
4 changes: 2 additions & 2 deletions analyzers/its/expected/akka.net/Akka.MultiNodeTestRunner--net471-S2094.json
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
"issues": [
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka.MultiNodeTestRunner\Program.cs",
"region": {
Expand All @@ -15,7 +15,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka.MultiNodeTestRunner\Program.cs",
"region": {
Expand Down
4 changes: 2 additions & 2 deletions analyzers/its/expected/akka.net/Akka.MultiNodeTestRunner--net5.0-S2094.json
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
"issues": [
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka.MultiNodeTestRunner\Program.cs",
"region": {
Expand All @@ -15,7 +15,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka.MultiNodeTestRunner\Program.cs",
"region": {
Expand Down
4 changes: 2 additions & 2 deletions analyzers/its/expected/akka.net/Akka.MultiNodeTestRunner--netcoreapp3.1-S2094.json
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
"issues": [
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka.MultiNodeTestRunner\Program.cs",
"region": {
Expand All @@ -15,7 +15,7 @@
},
{
"id": "S2094",
"message": "Remove this empty class, or add members to it.",
"message": "Remove this empty class, write its code or make it an "interface".",
"location": {
"uri": "sources\akka.net\src\core\Akka.MultiNodeTestRunner\Program.cs",
"region": {
Expand Down